You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "iercan (via GitHub)" <gi...@apache.org> on 2023/04/11 15:07:29 UTC
[GitHub] [superset] iercan opened a new issue, #23648: DASHBOARD_EDIT_CHART_IN_NEW_TAB feature flag is not working
iercan opened a new issue, #23648:
URL: https://github.com/apache/superset/issues/23648
DASHBOARD_EDIT_CHART_IN_NEW_TAB flag is not working on new version. I set it to True after upgrading latest version which is 2.1.0 but charts still opening in same page.
#### How to reproduce the bug
1. set DASHBOARD_EDIT_CHART_IN_NEW_TAB to true
2. Go to a dahsboard and try to edit a chart
### Expected results
Chart edit page should be opening new page.
### Actual results
Chart edit page opening same page
### Environment
(please complete the following information):
- browser type and version: Chrome 112.0.5615.49
- superset version: 2.1.0 installed with docker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] DASHBOARD_EDIT_CHART_IN_NEW_TAB feature flag is not working [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #23648: DASHBOARD_EDIT_CHART_IN_NEW_TAB feature flag is not working
URL: https://github.com/apache/superset/issues/23648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #23648: DASHBOARD_EDIT_CHART_IN_NEW_TAB feature flag is not working
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23648:
URL: https://github.com/apache/superset/issues/23648#issuecomment-1555462742
> Seems like no one care this bug :/
You can command-click the "Edit Chart" link to open it in a new tab, just like any other link on the web.
The "should it open in a new tab or not" debate goes back to when it was a JS function being fired rather than a normal link.
This flag is slated to be removed in 3.0 via [this PR](https://github.com/apache/superset/pull/23785).
I think this issue can stay open... I'm not sure why the flag isn't working in 2.1.0, and anyone is welcome to open a PR to fix it, which can be pulled into 2.1.1 or any subsequent 2.x.x patch versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] santosh-sahoo334 commented on issue #23648: DASHBOARD_EDIT_CHART_IN_NEW_TAB feature flag is not working
Posted by "santosh-sahoo334 (via GitHub)" <gi...@apache.org>.
santosh-sahoo334 commented on issue #23648:
URL: https://github.com/apache/superset/issues/23648#issuecomment-1537737209
Hi, I am Facing the same issue in release tag - v2.1.0. Its opening the charts in same window. Any workaround to fix this ? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #23648: DASHBOARD_EDIT_CHART_IN_NEW_TAB feature flag is not working
Posted by "iercan (via GitHub)" <gi...@apache.org>.
iercan commented on issue #23648:
URL: https://github.com/apache/superset/issues/23648#issuecomment-1539473829
Seems like no one care this bug :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] DASHBOARD_EDIT_CHART_IN_NEW_TAB feature flag is not working [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23648:
URL: https://github.com/apache/superset/issues/23648#issuecomment-1972126124
`DASHBOARD_EDIT_CHART_IN_NEW_TAB` no longer exists in supported versions of Superset. Closing. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org