[GitHub] [iceberg] openinx commented on a change in pull request #2859: Spark: Set properties for deletewriter

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2859:
URL: https://github.com/apache/iceberg/pull/2859#discussion_r676266247



##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java
##########
@@ -205,6 +205,7 @@ private StructType lazyPosDeleteSparkType() {
         case PARQUET:
           return Parquet.writeDeletes(file.encryptingOutputFile())
               .createWriterFunc(msgType -> SparkParquetWriters.buildWriter(lazyEqDeleteSparkType(), msgType))
+              .setAll(properties)

Review comment:
       Thanks for the contribution, @coolderli !  I also think the newPosDeleteWriter need the properties setting ...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org