You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by Nicholas DiPiazza <ni...@gmail.com> on 2024/04/10 05:16:44 UTC
Checkstyle - ignore line length or just use a bigger value
can we bump up the line break to a more reasonable number?
some of the stream expressions start to wrap and wrap and warp forcing me
to use smaller variable names or break down into methods when i'd otherwise
like not to.
Re: Checkstyle - ignore line length or just use a bigger value
Posted by Tim Allison <ta...@apache.org>.
There will be surprises. I'm not sure if the new streaming format will
work with checkstyle, etc...
We can iterate (or revert if anyone has a problem!)
On Wed, Apr 10, 2024 at 11:31 AM Nicholas DiPiazza
<ni...@gmail.com> wrote:
>
> Thank you so much for making these changes so fast. They will make my
> quality of life much better
>
> On Wed, Apr 10, 2024, 10:03 AM Tim Allison <ta...@apache.org> wrote:
>
> > I bumped line length to 180 from 120. Let's see if that's enough.
> >
> > I'm not sure what the best option is for chained method calls?
> > "Chained method calls" -> wrap always?
> > "Wrap first call" -> true
> > "Align with multiline" -> true
> >
> > I just pushed a slightly updated intellij-code-style.xml
> >
> > Let me know if that works.
> >
> > Fellow devs, if these modifications cause problems, please let me
> > know. I'm happy to revert!
> >
> >
> >
> > On Wed, Apr 10, 2024 at 10:29 AM Nicholas DiPiazza
> > <ni...@gmail.com> wrote:
> > >
> > > We could probably double it.
> > > and if there's some way to allow the Intellij formatter new line settings
> > > to allow multi-line streaming expressions
> > >
> > > builder()
> > > .name("nick")
> > > .someOtherStuff("doIt")
> > > .build()
> > >
> > > right now the formatter turns that into 1 line
> > >
> > > On Wed, Apr 10, 2024 at 5:06 AM Tim Allison <ta...@apache.org> wrote:
> > >
> > > > Sounds good. What length?
> > > >
> > > > On Wed, Apr 10, 2024 at 1:18 AM Nicholas DiPiazza
> > > > <ni...@gmail.com> wrote:
> > > > >
> > > > > can we bump up the line break to a more reasonable number?
> > > > > some of the stream expressions start to wrap and wrap and warp
> > forcing me
> > > > > to use smaller variable names or break down into methods when i'd
> > > > otherwise
> > > > > like not to.
> > > >
> >
Re: Checkstyle - ignore line length or just use a bigger value
Posted by Nicholas DiPiazza <ni...@gmail.com>.
Thank you so much for making these changes so fast. They will make my
quality of life much better
On Wed, Apr 10, 2024, 10:03 AM Tim Allison <ta...@apache.org> wrote:
> I bumped line length to 180 from 120. Let's see if that's enough.
>
> I'm not sure what the best option is for chained method calls?
> "Chained method calls" -> wrap always?
> "Wrap first call" -> true
> "Align with multiline" -> true
>
> I just pushed a slightly updated intellij-code-style.xml
>
> Let me know if that works.
>
> Fellow devs, if these modifications cause problems, please let me
> know. I'm happy to revert!
>
>
>
> On Wed, Apr 10, 2024 at 10:29 AM Nicholas DiPiazza
> <ni...@gmail.com> wrote:
> >
> > We could probably double it.
> > and if there's some way to allow the Intellij formatter new line settings
> > to allow multi-line streaming expressions
> >
> > builder()
> > .name("nick")
> > .someOtherStuff("doIt")
> > .build()
> >
> > right now the formatter turns that into 1 line
> >
> > On Wed, Apr 10, 2024 at 5:06 AM Tim Allison <ta...@apache.org> wrote:
> >
> > > Sounds good. What length?
> > >
> > > On Wed, Apr 10, 2024 at 1:18 AM Nicholas DiPiazza
> > > <ni...@gmail.com> wrote:
> > > >
> > > > can we bump up the line break to a more reasonable number?
> > > > some of the stream expressions start to wrap and wrap and warp
> forcing me
> > > > to use smaller variable names or break down into methods when i'd
> > > otherwise
> > > > like not to.
> > >
>
Re: Checkstyle - ignore line length or just use a bigger value
Posted by Tim Allison <ta...@apache.org>.
I bumped line length to 180 from 120. Let's see if that's enough.
I'm not sure what the best option is for chained method calls?
"Chained method calls" -> wrap always?
"Wrap first call" -> true
"Align with multiline" -> true
I just pushed a slightly updated intellij-code-style.xml
Let me know if that works.
Fellow devs, if these modifications cause problems, please let me
know. I'm happy to revert!
On Wed, Apr 10, 2024 at 10:29 AM Nicholas DiPiazza
<ni...@gmail.com> wrote:
>
> We could probably double it.
> and if there's some way to allow the Intellij formatter new line settings
> to allow multi-line streaming expressions
>
> builder()
> .name("nick")
> .someOtherStuff("doIt")
> .build()
>
> right now the formatter turns that into 1 line
>
> On Wed, Apr 10, 2024 at 5:06 AM Tim Allison <ta...@apache.org> wrote:
>
> > Sounds good. What length?
> >
> > On Wed, Apr 10, 2024 at 1:18 AM Nicholas DiPiazza
> > <ni...@gmail.com> wrote:
> > >
> > > can we bump up the line break to a more reasonable number?
> > > some of the stream expressions start to wrap and wrap and warp forcing me
> > > to use smaller variable names or break down into methods when i'd
> > otherwise
> > > like not to.
> >
Re: Checkstyle - ignore line length or just use a bigger value
Posted by Nicholas DiPiazza <ni...@gmail.com>.
We could probably double it.
and if there's some way to allow the Intellij formatter new line settings
to allow multi-line streaming expressions
builder()
.name("nick")
.someOtherStuff("doIt")
.build()
right now the formatter turns that into 1 line
On Wed, Apr 10, 2024 at 5:06 AM Tim Allison <ta...@apache.org> wrote:
> Sounds good. What length?
>
> On Wed, Apr 10, 2024 at 1:18 AM Nicholas DiPiazza
> <ni...@gmail.com> wrote:
> >
> > can we bump up the line break to a more reasonable number?
> > some of the stream expressions start to wrap and wrap and warp forcing me
> > to use smaller variable names or break down into methods when i'd
> otherwise
> > like not to.
>
Re: Checkstyle - ignore line length or just use a bigger value
Posted by Tim Allison <ta...@apache.org>.
Sounds good. What length?
On Wed, Apr 10, 2024 at 1:18 AM Nicholas DiPiazza
<ni...@gmail.com> wrote:
>
> can we bump up the line break to a more reasonable number?
> some of the stream expressions start to wrap and wrap and warp forcing me
> to use smaller variable names or break down into methods when i'd otherwise
> like not to.