You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2015/01/22 22:42:00 UTC

Review Request 30193: Method call SqoopClient.getJobsByConnector from the client is not supported

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30193/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2029
    https://issues.apache.org/jira/browse/SQOOP-2029


Repository: sqoop-sqoop2


Description
-------

see jirs


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 6efa016 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java c95686d 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a74a56d 
  common/src/main/java/org/apache/sqoop/model/Config.java 644cffe 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java 0d15d0a 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 98363fa 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf 
  shell/src/main/resources/shell-resource.properties 6a64fcc 

Diff: https://reviews.apache.org/r/30193/diff/


Testing
-------


Thanks,

Veena Basavaraj

Re: Review Request 30193: Method call SqoopClient.getJobsByConnector from the client is not supported

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30193/#review69365
-----------------------------------------------------------

Ship it!


LGTM


client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/30193/#comment114053>

    Wrong line?



shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
<https://reviews.apache.org/r/30193/#comment114054>

    RES_SHOW_PROMPT_DISPLAY_ALL_JOBS_CID => RES_SHOW_PROMPT_DISPLAY_JOBS_CID for consistency with RES_SHOW_PROMPT_DISPLAY_JOB_JID?


- Abraham Elmahrek


On Jan. 22, 2015, 9:43 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30193/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 9:43 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2029
>     https://issues.apache.org/jira/browse/SQOOP-2029
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jirs
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 6efa016 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java c95686d 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a74a56d 
>   common/src/main/java/org/apache/sqoop/model/Config.java 644cffe 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java 0d15d0a 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 98363fa 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf 
>   shell/src/main/resources/shell-resource.properties 6a64fcc 
> 
> Diff: https://reviews.apache.org/r/30193/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 30193: Method call SqoopClient.getJobsByConnector from the client is not supported

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30193/#review69517
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Elmahrek


On Jan. 23, 2015, 9:06 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30193/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 9:06 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2029
>     https://issues.apache.org/jira/browse/SQOOP-2029
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jirs
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 6efa016 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java c95686d 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a74a56d 
>   common/src/main/java/org/apache/sqoop/model/Config.java 644cffe 
>   server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java 0d15d0a 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 98363fa 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf 
>   shell/src/main/resources/shell-resource.properties 6a64fcc 
> 
> Diff: https://reviews.apache.org/r/30193/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>

Re: Review Request 30193: Method call SqoopClient.getJobsByConnector from the client is not supported

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30193/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 1:06 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2029
    https://issues.apache.org/jira/browse/SQOOP-2029


Repository: sqoop-sqoop2


Description
-------

see jirs


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 6efa016 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java c95686d 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a74a56d 
  common/src/main/java/org/apache/sqoop/model/Config.java 644cffe 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java 0d15d0a 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 98363fa 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf 
  shell/src/main/resources/shell-resource.properties 6a64fcc 

Diff: https://reviews.apache.org/r/30193/diff/


Testing
-------


Thanks,

Veena Basavaraj

Re: Review Request 30193: Method call SqoopClient.getJobsByConnector from the client is not supported

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30193/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 12:04 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2029
    https://issues.apache.org/jira/browse/SQOOP-2029


Repository: sqoop-sqoop2


Description
-------

see jirs


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 6efa016 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java c95686d 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a74a56d 
  common/src/main/java/org/apache/sqoop/model/Config.java 644cffe 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java 0d15d0a 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 98363fa 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf 
  shell/src/main/resources/shell-resource.properties 6a64fcc 

Diff: https://reviews.apache.org/r/30193/diff/


Testing
-------


Thanks,

Veena Basavaraj

Re: Review Request 30193: Method call SqoopClient.getJobsByConnector from the client is not supported

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30193/
-----------------------------------------------------------

(Updated Jan. 22, 2015, 1:43 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2029
    https://issues.apache.org/jira/browse/SQOOP-2029


Repository: sqoop-sqoop2


Description
-------

see jirs


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 6efa016 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java c95686d 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a74a56d 
  common/src/main/java/org/apache/sqoop/model/Config.java 644cffe 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java 0d15d0a 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 98363fa 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf 
  shell/src/main/resources/shell-resource.properties 6a64fcc 

Diff: https://reviews.apache.org/r/30193/diff/


Testing
-------


Thanks,

Veena Basavaraj

Re: Review Request 30193: Method call SqoopClient.getJobsByConnector from the client is not supported

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30193/
-----------------------------------------------------------

(Updated Jan. 22, 2015, 1:43 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2029
    https://issues.apache.org/jira/browse/SQOOP-2029


Repository: sqoop-sqoop2


Description
-------

see jirs


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 6efa016 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java c95686d 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a74a56d 
  common/src/main/java/org/apache/sqoop/model/Config.java 644cffe 
  server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java 0d15d0a 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 98363fa 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 98d8cbf 
  shell/src/main/resources/shell-resource.properties 6a64fcc 

Diff: https://reviews.apache.org/r/30193/diff/


Testing
-------


Thanks,

Veena Basavaraj