[jira] Updated: (SOLR-423) SolrRequestHandler close notification

["Grant Ingersoll (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-423:
---------------------------------

    Attachment: SOLR-423.patch

Draft patch that implements close() callback on the SolrRequestHandler and provides empty implementation for RequestHandlerBase.

Obviously, this is not backward compatible since it adds a new method to an interface, but I am not sure where else to put it for now.  My guess is most people extend RequestHandlerBase anyway, so it may not be that big of an issue.

Patch hooks into the SolrCore.close() call by calling RequestHandlers.closeHandlers() similar to how it inits the handlers.

All tests should pass.  Also added a test to SolrCoreTest to explicitly check that close is being called.

> SolrRequestHandler close notification
> -------------------------------------
>
>                 Key: SOLR-423
>                 URL: https://issues.apache.org/jira/browse/SOLR-423
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-423.patch
>
>
> It may be beneficial for implementations of SolrRequestHandler to be notified that the SolrCore is closing so that they can release any resources that they may have open.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.