start-commit bug?

[Jay Flaherty <jf...@convio.com>]

I came across what I think is a bug with the start-commit hook. Have not found evidence that this is a know bug.
Submitting here before I post to the dev list.

I am running ver. 1.5.0 of the server and client.
I have authentication on for select users with write access
I have a start-commit hook that checks the capabilities parameter for the 'mergeinfo' string.
This hook script rejects the commit and throws an error if this string does not exist.

Everything works fine if you are already authenticated but if you need to authenticate then 
the capabilities parameter is empty and the start-hook an error.

Steps to reproduce:
using ver. 1.5.0 of the client and server:
   1. create a start-commit hook script (see attachments)
   2. checkout some project from your repository and make some changes
   3. delete ~/.subversion/auth directory
   4. commit changes to your repository (should ask for your username/password)
   5. authenticate yourself

expected results:
   1. should allow you commit your changes

actual results:
   1. rejects commit and spews out error message from the hook script.

Is this a known bug and can anybody else verify this?

Thanks,

Jay

Re: start-commit bug?

[Karl Fogel <kf...@red-bean.com>]

"Jay Flaherty" <jf...@convio.com> writes:
> I came across what I think is a bug with the start-commit hook. Have not found
> evidence that this is a know bug.
> Submitting here before I post to the dev list.
>
> I am running ver. 1.5.0 of the server and client.
> I have authentication on for select users with write access
> I have a start-commit hook that checks the capabilities parameter for the
> 'mergeinfo' string.
> This hook script rejects the commit and throws an error if this string does not
> exist.
>
> Everything works fine if you are already authenticated but if you need to
> authenticate then
> the capabilities parameter is empty and the start-hook an error.

It looks like we made some changes related to this in r31620 and r31622,
but they were just about fixing a bug on the server to avoid a crash (or
something) when the client fails to report capabilities.  There was no
fix for the bug of the client not reporting the capabilities in the
first place.

I'm not sure why we're not reporting capabilities.  Could you file this
as an issue, so at least we have a place to track it?  (I'm busy working
on issue #2843 right now, so can't look into this.)  Link back to this
thread, include the reproduction recipe directly in the issue, and put
the start-commit hook on the issue as an attachment.

By the way, I searched and didn't find an existing issue for this.  I
don't know if it's a regression or not; if you have time to test with
older releases and find out, that would be a huge help.

-Karl


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: start-commit bug?

[Jacky <wy...@gmail.com>]

Hi Jay,

My earlier post address the same issue, yet no one reply yet. This issue 
happens when you use mod_dav_svn (http://... as URL). But it works if 
you use svnserve as backend (svn://...). It looks like a bug.

Jacky.

Jay Flaherty wrote:
>
> I came across what I think is a bug with the start-commit hook. Have 
> not found evidence that this is a know bug.
> Submitting here before I post to the dev list.
>
> I am running ver. 1.5.0 of the server and client.
> I have authentication on for select users with write access
> I have a start-commit hook that checks the capabilities parameter for 
> the 'mergeinfo' string.
> This hook script rejects the commit and throws an error if this string 
> does not exist.
>
> Everything works fine if you are already authenticated but if you need 
> to authenticate then
> the capabilities parameter is empty and the start-hook an error.
>
> Steps to reproduce:
> using ver. 1.5.0 of the client and server:
>    1. create a start-commit hook script (see attachments)
>    2. checkout some project from your repository and make some changes
>    3. delete ~/.subversion/auth directory
>    4. commit changes to your repository (should ask for your 
> username/password)
>    5. authenticate yourself
>
> expected results:
>    1. should allow you commit your changes
>
> actual results:
>    1. rejects commit and spews out error message from the hook script.
>
> Is this a known bug and can anybody else verify this?
>
> Thanks,
>
> Jay
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: users-help@subversion.tigris.org


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org