[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487274180



##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
     "rison": "^0.1.1",
     "shortid": "^2.2.6",
     "urijs": "^1.18.10",
-    "use-query-params": "^0.4.5"
+    "use-query-params": "^0.4.5",
+    "zlib": "^1.0.5"

Review comment:
       These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org