You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/07/11 01:00:29 UTC
[kudu-CR] spark: Expose socketReadTimeoutMs to Spark connector
Hello Dan Burkert, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10839
to look at the new patch set (#3).
Change subject: spark: Expose socketReadTimeoutMs to Spark connector
......................................................................
spark: Expose socketReadTimeoutMs to Spark connector
This patch exposes socketReadTimeoutMs in the KuduContext and the
DefaultSource.
This patch also performs a bit of cleanup by renaming
the KuduConnection object to KuduClientCache, which seems like a more
appropriate name.
Because socketReadTimeout is a KuduClient configuration parameter
related to connection handling, socketReadTimeout was incorporated into
the client cache key.
Manually tested in spark-shell using spark-on-yarn.
Added a basic test to ensure that the parameter is properly parsed by
the DefaultSource and configured in the KuduRelation instance.
Change-Id: I0ab0ff0b242790caffb7e2848958148ffe547c4d
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
5 files changed, 68 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/10839/3
--
To view, visit http://gerrit.cloudera.org:8080/10839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ab0ff0b242790caffb7e2848958148ffe547c4d
Gerrit-Change-Number: 10839
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins