You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2007/03/08 14:02:24 UTC
[jira] Created: (HADOOP-1090) In SortValidator, the check for
whether a file belongs to sort-input or sort-output dir is weak
In SortValidator, the check for whether a file belongs to sort-input or sort-output dir is weak
-----------------------------------------------------------------------------------------------
Key: HADOOP-1090
URL: https://issues.apache.org/jira/browse/HADOOP-1090
Project: Hadoop
Issue Type: Bug
Components: mapred
Reporter: Devaraj Das
Assigned To: Arun C Murthy
In SortValidator, Maps invoke the method called deduceInputFile in the configure method. The deduceInputFile is supposed to return whether the input file belongs to the sort-input directory or the sort-output directory. However, the check that deduceInputFile does - inputFile.toString().startsWith(inputPaths[0].toString()) - is not totally correct. The check will always returns true for inputPaths like /user/foo/smallInput/<filenames>, /user/foo/smallInput-sorted/<filenames>. This finally causes the SortValidator to declare the sort output as incorrect.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1090) In SortValidator, the check for
whether a file belongs to sort-input or sort-output dir is weak
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-1090:
----------------------------------
Attachment: HADOOP-1090_20070331_1.patch
Simple fix...
> In SortValidator, the check for whether a file belongs to sort-input or sort-output dir is weak
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-1090
> URL: https://issues.apache.org/jira/browse/HADOOP-1090
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assigned To: Arun C Murthy
> Attachments: HADOOP-1090_20070331_1.patch
>
>
> In SortValidator, Maps invoke the method called deduceInputFile in the configure method. The deduceInputFile is supposed to return whether the input file belongs to the sort-input directory or the sort-output directory. However, the check that deduceInputFile does - inputFile.toString().startsWith(inputPaths[0].toString()) - is not totally correct. The check will always returns true for inputPaths like /user/foo/smallInput/<filenames>, /user/foo/smallInput-sorted/<filenames>. This finally causes the SortValidator to declare the sort output as incorrect.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1090) In SortValidator, the check for
whether a file belongs to sort-input or sort-output dir is weak
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-1090:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Arun!
> In SortValidator, the check for whether a file belongs to sort-input or sort-output dir is weak
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-1090
> URL: https://issues.apache.org/jira/browse/HADOOP-1090
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.2
> Reporter: Devaraj Das
> Assigned To: Arun C Murthy
> Fix For: 0.13.0
>
> Attachments: HADOOP-1090_20070331_1.patch
>
>
> In SortValidator, Maps invoke the method called deduceInputFile in the configure method. The deduceInputFile is supposed to return whether the input file belongs to the sort-input directory or the sort-output directory. However, the check that deduceInputFile does - inputFile.toString().startsWith(inputPaths[0].toString()) - is not totally correct. The check will always returns true for inputPaths like /user/foo/smallInput/<filenames>, /user/foo/smallInput-sorted/<filenames>. This finally causes the SortValidator to declare the sort output as incorrect.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1090) In SortValidator, the check for
whether a file belongs to sort-input or sort-output dir is weak
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485985 ]
Hadoop QA commented on HADOOP-1090:
-----------------------------------
Integrated in Hadoop-Nightly #45 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/45/)
> In SortValidator, the check for whether a file belongs to sort-input or sort-output dir is weak
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-1090
> URL: https://issues.apache.org/jira/browse/HADOOP-1090
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.2
> Reporter: Devaraj Das
> Assigned To: Arun C Murthy
> Fix For: 0.13.0
>
> Attachments: HADOOP-1090_20070331_1.patch
>
>
> In SortValidator, Maps invoke the method called deduceInputFile in the configure method. The deduceInputFile is supposed to return whether the input file belongs to the sort-input directory or the sort-output directory. However, the check that deduceInputFile does - inputFile.toString().startsWith(inputPaths[0].toString()) - is not totally correct. The check will always returns true for inputPaths like /user/foo/smallInput/<filenames>, /user/foo/smallInput-sorted/<filenames>. This finally causes the SortValidator to declare the sort output as incorrect.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1090) In SortValidator, the check for
whether a file belongs to sort-input or sort-output dir is weak
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-1090:
----------------------------------
Fix Version/s: 0.13.0
Affects Version/s: 0.12.2
Status: Patch Available (was: Open)
> In SortValidator, the check for whether a file belongs to sort-input or sort-output dir is weak
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-1090
> URL: https://issues.apache.org/jira/browse/HADOOP-1090
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.2
> Reporter: Devaraj Das
> Assigned To: Arun C Murthy
> Fix For: 0.13.0
>
> Attachments: HADOOP-1090_20070331_1.patch
>
>
> In SortValidator, Maps invoke the method called deduceInputFile in the configure method. The deduceInputFile is supposed to return whether the input file belongs to the sort-input directory or the sort-output directory. However, the check that deduceInputFile does - inputFile.toString().startsWith(inputPaths[0].toString()) - is not totally correct. The check will always returns true for inputPaths like /user/foo/smallInput/<filenames>, /user/foo/smallInput-sorted/<filenames>. This finally causes the SortValidator to declare the sort output as incorrect.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.