[GitHub] [pinot] snleee commented on a diff in pull request #8314: Access Control management Development

[GitBox <gi...@apache.org>]

snleee commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r852505186


##########
pinot-common/pom.xml:
##########
@@ -301,6 +301,11 @@
       <groupId>org.apache.yetus</groupId>
       <artifactId>audience-annotations</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.mindrot</groupId>
+      <artifactId>jbcrypt</artifactId>
+      <version>0.4</version>
+    </dependency>

Review Comment:
   The license for `jBCrypt`looks to be not the standard license like BSD 2,3 clause or MIT. Is it possible to use this instead? Spring is based on apache license 
   https://docs.spring.io/spring-security/site/docs/current/api/org/springframework/security/crypto/bcrypt/BCrypt.html
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org