[GitHub] [spark] HeartSaVioR commented on a change in pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #28391:
URL: https://github.com/apache/spark/pull/28391#discussion_r437051581



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingDeduplicationSuite.scala
##########
@@ -270,7 +271,12 @@ class StreamingDeduplicationSuite extends StateStoreMetricsTest {
         .select($"eventTime".cast("long").as[Long])
 
       testStream(result, Append)(
-        StartStream(additionalConfs = Map(flagKey -> flag.toString)),
+        StartStream(additionalConfs = Map(
+          noDataBatchEnableKey -> flag.toString,
+          // set `STREAMING_NO_DATA_PROGRESS_EVENT_INTERVAL` a small value to
+          // report an `empty` progress when no data come.
+          noDataProgressIntervalKey -> "1")

Review comment:
       SPARK-31928 is filed to address the flakiness of this test on the master branch - that said, if we can make sure this test become no longer flaky, that should be nice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org