[jira] [Commented] (PHOENIX-1646) Views and functional index expressions may lose information when stringified

["Thomas D'Silva (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313395#comment-14313395 ] 

Thomas D'Silva commented on PHOENIX-1646:
-----------------------------------------

+1 

I think the patch looks good.

minor typo in NamedParseNode.java

{code}
+    protected NamedNode getNameedNode() {
+        return namedNode;
+    }
+    
{code}

> Views and functional index expressions may lose information when stringified
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-1646
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1646
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>         Attachments: PHOENIX-1646-wip.patch, PHOENIX-1646.patch, PHOENIX-1646_v2.patch
>
>
> We currently produce a string from an Expression to store in the system catalog for views and functional indexes. However there are a number of constructs that won't roundtrip correctly, mainly due to the way expression trees get collapsed during compilation. The easiest way to fix this is to go from the ParseNode to a string instead and fully resolve column names in the process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)