You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/01/11 02:17:12 UTC

[GitHub] [incubator-yunikorn-k8shim] yuchaoran2011 commented on a change in pull request #346: [YUNIKORN-941] Split scheduler and admission controller deployments

yuchaoran2011 commented on a change in pull request #346:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/346#discussion_r781711114



##########
File path: scripts/run-e2e-tests.sh
##########
@@ -115,14 +115,16 @@ function check_opt() {
 }
 
 function install_cluster() {
-  # both arguments are required
-  if [[ $# -ne 2 ]]; then
-    echo "expecting exact 2 parameters for function install_cluster()"
+  # 4 arguments are required
+  if [[ $# -ne 4 ]]; then
+    echo "expecting exactly parameters for function install_cluster()"

Review comment:
       You meant to say "exactly 4" I assume




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org