You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/05/08 22:08:27 UTC
[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2667
STORM-3063: Fix minor pom issues
https://issues.apache.org/jira/browse/STORM-3063
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-3063
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2667.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2667
----
commit 51b1faa93cd29248e85dd76cd73e226b7b58eeed
Author: Stig Rohde Døssing <sr...@...>
Date: 2018-05-06T11:54:06Z
STORM-3063: Fix minor pom issues
----
---
[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2667#discussion_r186888587
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
<useStandardDocletOptions>true</useStandardDocletOptions>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-maven</id>
--- End diff --
No, it could be left out. However I think since this plugin is so generic, it's helpful to have a descriptive name for the execution.
---
[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2667#discussion_r187100434
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
<useStandardDocletOptions>true</useStandardDocletOptions>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-maven</id>
--- End diff --
Yes, that's better. Will change.
---
[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2667#discussion_r187100160
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
<useStandardDocletOptions>true</useStandardDocletOptions>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-maven</id>
--- End diff --
Agree. Would 'enforce-maven-version' be more descriptive?
---
[GitHub] storm issue #2667: STORM-3063: Fix minor pom issues
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2667
+1
---
[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2667
---
[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2667#discussion_r186887493
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
<useStandardDocletOptions>true</useStandardDocletOptions>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-maven</id>
--- End diff --
since there is only one execution, is 'id' really necessary ?
---