You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "jmalkin (via GitHub)" <gi...@apache.org> on 2023/01/28 03:18:46 UTC
[GitHub] [datasketches-cpp] jmalkin opened a new pull request, #339: ensure we use std::abs() everywhere
jmalkin opened a new pull request, #339:
URL: https://github.com/apache/datasketches-cpp/pull/339
Was playing with compiler warning flags and it pointed out that we were calling the integer abs() on float values, so I decided to ensure we're using std::abs() globally, even where we had fabs() before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls commented on pull request #339: ensure we use std::abs() everywhere
Posted by "coveralls (via GitHub)" <gi...@apache.org>.
coveralls commented on PR #339:
URL: https://github.com/apache/datasketches-cpp/pull/339#issuecomment-1407272542
## Pull Request Test Coverage Report for [Build 4029944610](https://coveralls.io/builds/56373925)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **93.871%**
---
| Totals | [](https://coveralls.io/builds/56373925) |
| :-- | --: |
| Change from base [Build 4029599866](https://coveralls.io/builds/56373399): | 0.0% |
| Covered Lines: | 2328 |
| Relevant Lines: | 2480 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin merged pull request #339: ensure we use std::abs() everywhere
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin merged PR #339:
URL: https://github.com/apache/datasketches-cpp/pull/339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org