You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by César Hernández Mendoza <ce...@gmail.com> on 2019/04/12 16:04:59 UTC
TOMEE-2492 - Creates Unit test to CmpJpaConversion
Hi Otavio,
I assigned to you TOMEE-2492 since you already have a PR open.
Can you please share in this thread on what problem this PR solves and what
people should know so they can review it.
---------- Forwarded message ---------
De: GitBox <gi...@apache.org>
Date: jue., 7 mar. 2019 a las 6:12
Subject: [GitHub] [tomee] otaviojava commented on issue #422: Creates Unit
test to CmpJpaConversion
To: <de...@tomee.apache.org>
otaviojava commented on issue #422: Creates Unit test to CmpJpaConversion
URL: https://github.com/apache/tomee/pull/422#issuecomment-470502867
@jgallimore when you have time, could you review/merge this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
--
Atentamente:
César Hernández.
Re: TOMEE-2492 - Creates Unit test to CmpJpaConversion
Posted by Otávio Gonçalves de Santana <os...@tomitribe.com>.
I also fired a ticket: https://issues.apache.org/jira/browse/TOMEE-2492
On Mon, Apr 15, 2019 at 8:42 AM Otávio Gonçalves de Santana <
osantana@tomitribe.com> wrote:
> The goal of this issue is to create a unit test at CmpJpaConversion and
> also based on these test make sure that any change does not change the
> desired behavior from the class.
>
> On Fri, Apr 12, 2019 at 1:05 PM César Hernández Mendoza <
> cesarguate@gmail.com> wrote:
>
>> Hi Otavio,
>>
>> I assigned to you TOMEE-2492 since you already have a PR open.
>> Can you please share in this thread on what problem this PR solves and
>> what
>> people should know so they can review it.
>>
>>
>>
>> ---------- Forwarded message ---------
>> De: GitBox <gi...@apache.org>
>> Date: jue., 7 mar. 2019 a las 6:12
>> Subject: [GitHub] [tomee] otaviojava commented on issue #422: Creates Unit
>> test to CmpJpaConversion
>> To: <de...@tomee.apache.org>
>>
>>
>> otaviojava commented on issue #422: Creates Unit test to CmpJpaConversion
>> URL: https://github.com/apache/tomee/pull/422#issuecomment-470502867
>>
>>
>> @jgallimore when you have time, could you review/merge this PR?
>>
>> ----------------------------------------------------------------
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>>
>> With regards,
>> Apache Git Services
>>
>>
>> --
>> Atentamente:
>> César Hernández.
>>
>
Re: TOMEE-2492 - Creates Unit test to CmpJpaConversion
Posted by Otávio Gonçalves de Santana <os...@tomitribe.com>.
The goal of this issue is to create a unit test at CmpJpaConversion and
also based on these test make sure that any change does not change the
desired behavior from the class.
On Fri, Apr 12, 2019 at 1:05 PM César Hernández Mendoza <
cesarguate@gmail.com> wrote:
> Hi Otavio,
>
> I assigned to you TOMEE-2492 since you already have a PR open.
> Can you please share in this thread on what problem this PR solves and what
> people should know so they can review it.
>
>
>
> ---------- Forwarded message ---------
> De: GitBox <gi...@apache.org>
> Date: jue., 7 mar. 2019 a las 6:12
> Subject: [GitHub] [tomee] otaviojava commented on issue #422: Creates Unit
> test to CmpJpaConversion
> To: <de...@tomee.apache.org>
>
>
> otaviojava commented on issue #422: Creates Unit test to CmpJpaConversion
> URL: https://github.com/apache/tomee/pull/422#issuecomment-470502867
>
>
> @jgallimore when you have time, could you review/merge this PR?
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>
>
> --
> Atentamente:
> César Hernández.
>