You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/06/09 01:24:30 UTC

[GitHub] [james-project] Arsnael commented on pull request #423: WIP: JAMES-XXXX Handle JMAP WebSocket ping

Arsnael commented on pull request #423:
URL: https://github.com/apache/james-project/pull/423#issuecomment-857300204


   What is left to do here except maybe testing with Gatling? 
   
   I reverted the last commit. Maybe on the CI it was fine but locally for the distributed tests some were unstable, regarding the way some tests are being built. Like we would sometimes expect 3 responses on the websocket after sending some requests threw it, but if your ping interval is low enough, you would get some ping responses mixed instead, which fails the assert of the test. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org