You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2021/04/19 16:31:25 UTC
[Impala-ASF-CR] IMPALA-10611: Fix flakiness in test wide row
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17324
Change subject: IMPALA-10611: Fix flakiness in test_wide_row
......................................................................
IMPALA-10611: Fix flakiness in test_wide_row
test_wide_row has been intermittently failed with "Failed to allocate
row batch" error message. This is due to recent change in IMPALA-9856
that add query option max_row_size=10MB without raising the mem_limit.
This patch fix the flakiness by increasing the mem_limit from 100 MB to
132 MB to account for 32 MB reservation needed by BufferedPlanRootSink.
Testing:
- Loop the test in local dev machine.
Change-Id: Ie1f0b7d4d6b3a875d9b408f057d46fdbdbdf2a34
---
M tests/query_test/test_scanners.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/17324/1
--
To view, visit http://gerrit.cloudera.org:8080/17324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1f0b7d4d6b3a875d9b408f057d46fdbdbdf2a34
Gerrit-Change-Number: 17324
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-10611: Fix flakiness in test wide row
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17324 )
Change subject: IMPALA-10611: Fix flakiness in test_wide_row
......................................................................
Patch Set 1: Code-Review+2
I'm OK with this fix but maybe we should also re-open IMPALA-681.
--
To view, visit http://gerrit.cloudera.org:8080/17324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f0b7d4d6b3a875d9b408f057d46fdbdbdf2a34
Gerrit-Change-Number: 17324
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Apr 2021 12:50:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10611: Fix flakiness in test wide row
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17324 )
Change subject: IMPALA-10611: Fix flakiness in test_wide_row
......................................................................
IMPALA-10611: Fix flakiness in test_wide_row
test_wide_row has been intermittently failed with "Failed to allocate
row batch" error message. This is due to recent change in IMPALA-9856
that add query option max_row_size=10MB without raising the mem_limit.
This patch fix the flakiness by increasing the mem_limit from 100 MB to
132 MB to account for 32 MB reservation needed by BufferedPlanRootSink.
Testing:
- Loop the test in local dev machine.
Change-Id: Ie1f0b7d4d6b3a875d9b408f057d46fdbdbdf2a34
Reviewed-on: http://gerrit.cloudera.org:8080/17324
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_scanners.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1f0b7d4d6b3a875d9b408f057d46fdbdbdf2a34
Gerrit-Change-Number: 17324
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10611: Fix flakiness in test wide row
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17324 )
Change subject: IMPALA-10611: Fix flakiness in test_wide_row
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f0b7d4d6b3a875d9b408f057d46fdbdbdf2a34
Gerrit-Change-Number: 17324
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Apr 2021 21:12:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10611: Fix flakiness in test wide row
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17324 )
Change subject: IMPALA-10611: Fix flakiness in test_wide_row
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7095/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f0b7d4d6b3a875d9b408f057d46fdbdbdf2a34
Gerrit-Change-Number: 17324
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Apr 2021 15:26:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10611: Fix flakiness in test wide row
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17324 )
Change subject: IMPALA-10611: Fix flakiness in test_wide_row
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8596/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f0b7d4d6b3a875d9b408f057d46fdbdbdf2a34
Gerrit-Change-Number: 17324
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Apr 2021 16:51:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10611: Fix flakiness in test wide row
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17324 )
Change subject: IMPALA-10611: Fix flakiness in test_wide_row
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f0b7d4d6b3a875d9b408f057d46fdbdbdf2a34
Gerrit-Change-Number: 17324
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Apr 2021 15:26:31 +0000
Gerrit-HasComments: No