You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Henri Yandell <fl...@gmail.com> on 2009/02/27 10:50:21 UTC
[VOTE] Release of CLI 1.2 RC3
Gary's regression bug is fixed. So voting again.
Tag:
https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3
Site remains unchanged:
http://people.apache.org/~bayard/cli-1.2-rc1
Binaries:
http://people.apache.org/builds/commons/cli/1.2/RC3/staged/commons-cli/commons-cli/1.2/
[ ] +1 release it
[ ] +0 go ahead I don't care
[ ] -1 no, do not release it because
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of CLI 1.2 RC3
Posted by Russel Winder <ru...@concertant.com>.
Henri
As previously, I built a commons-cli-1.2.jar from the branch rather than
the tag, so I am not really testing the RC-3 per se -- but they should
be identical :-)
Groovy and Gant both pass all their tests fine as far as I can see.
If I get a vote, I vote for release.
On Fri, 2009-02-27 at 01:50 -0800, Henri Yandell wrote:
> Gary's regression bug is fixed. So voting again.
>
>
> Tag:
>
> https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3
>
> Site remains unchanged:
>
> http://people.apache.org/~bayard/cli-1.2-rc1
>
> Binaries:
>
> http://people.apache.org/builds/commons/cli/1.2/RC3/staged/commons-cli/commons-cli/1.2/
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
--
Russel.
====================================================
Dr Russel Winder Partner
Concertant LLP t: +44 20 7585 2200, +44 20 7193 9203
41 Buckmaster Road, f: +44 8700 516 084
London SW11 1EN, UK. m: +44 7770 465 077
Re: [VOTE] Release of CLI 1.2 RC3
Posted by Jörg Schaible <jo...@gmx.de>.
Hi Henri,
Henri Yandell wrote at Samstag, 28. Februar 2009 21:15:
> I've fixed the first one - or should have (as I'm not setup to test).
> Not a blocker on release though imo.
Agreed.
> The second does not look like it'll have come about due to new code -
> it was an attempt to increase code coverage so the bug is extremely
> likely to already exist in 1.0, 1.1 etc. Not a blocker I think.
As this only happens on one vendor's JDK, you're right.
So +1 for the release.
However, I am still wondering, how this test can fail at all with the result
below.
- Jörg
>
> Hen
>
> On Sat, Feb 28, 2009 at 8:47 AM, Jörg Schaible <jo...@gmx.de>
> wrote:
>> Hi Henry,
>>
>> Henri Yandell wrote:
>>
>>> Are these new errors Jörg, or do they happen with 1.1?
>>
>> Hardly, both tests did not exist yet in 1.1 ;-)
>>
>> OptionGroupTest.toString fails, because the option group is based on a
>> HashMap which is printed in arbitrary order. Since the options are
>> mutually exclusive, this is fine. I can commit an updated test at any
>> time.
>>
>> However, HelpFormatterTest.printOptionGroup is different and gives me
>> really a headache. The test fails when I run it using Maven. In Eclipse
>> (also with IBM JDK 1.6) it does not fail.
>>
>> Have a look at the test code:
>>
>> ========== %< =============
>> OptionGroup group = new OptionGroup();
>> group.addOption(OptionBuilder.create("a"));
>> group.addOption(OptionBuilder.create("b"));
>> group.addOption(OptionBuilder.create("c"));
>>
>> Options options = new Options();
>> options.addOptionGroup(group);
>>
>> StringWriter out = new StringWriter();
>>
>> HelpFormatter formatter = new HelpFormatter();
>> formatter.printUsage(new PrintWriter(out), 80, "app", options);
>>
>> System.out.println(out.toString());
>> assertEquals("usage: app [-a | -b | -c]" + EOL, out.toString());
>> ========== %< =============
>>
>> I have no idea, what causes the combo Maven/IBM JDK 6 to render a String
>> of "usage: app [-a <arg>| -b | -c]" here. It simply does not make sence,
>> but it is reproducible on every run.
>>
>> - Jörg
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of CLI 1.2 RC3
Posted by Henri Yandell <fl...@gmail.com>.
I've fixed the first one - or should have (as I'm not setup to test).
Not a blocker on release though imo.
The second does not look like it'll have come about due to new code -
it was an attempt to increase code coverage so the bug is extremely
likely to already exist in 1.0, 1.1 etc. Not a blocker I think.
Hen
On Sat, Feb 28, 2009 at 8:47 AM, Jörg Schaible <jo...@gmx.de> wrote:
> Hi Henry,
>
> Henri Yandell wrote:
>
>> Are these new errors Jörg, or do they happen with 1.1?
>
> Hardly, both tests did not exist yet in 1.1 ;-)
>
> OptionGroupTest.toString fails, because the option group is based on a
> HashMap which is printed in arbitrary order. Since the options are mutually
> exclusive, this is fine. I can commit an updated test at any time.
>
> However, HelpFormatterTest.printOptionGroup is different and gives me really
> a headache. The test fails when I run it using Maven. In Eclipse (also with
> IBM JDK 1.6) it does not fail.
>
> Have a look at the test code:
>
> ========== %< =============
> OptionGroup group = new OptionGroup();
> group.addOption(OptionBuilder.create("a"));
> group.addOption(OptionBuilder.create("b"));
> group.addOption(OptionBuilder.create("c"));
>
> Options options = new Options();
> options.addOptionGroup(group);
>
> StringWriter out = new StringWriter();
>
> HelpFormatter formatter = new HelpFormatter();
> formatter.printUsage(new PrintWriter(out), 80, "app", options);
>
> System.out.println(out.toString());
> assertEquals("usage: app [-a | -b | -c]" + EOL, out.toString());
> ========== %< =============
>
> I have no idea, what causes the combo Maven/IBM JDK 6 to render a String
> of "usage: app [-a <arg>| -b | -c]" here. It simply does not make sence,
> but it is reproducible on every run.
>
> - Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of CLI 1.2 RC3
Posted by Jörg Schaible <jo...@gmx.de>.
Hi Henry,
Henri Yandell wrote:
> Are these new errors Jörg, or do they happen with 1.1?
Hardly, both tests did not exist yet in 1.1 ;-)
OptionGroupTest.toString fails, because the option group is based on a
HashMap which is printed in arbitrary order. Since the options are mutually
exclusive, this is fine. I can commit an updated test at any time.
However, HelpFormatterTest.printOptionGroup is different and gives me really
a headache. The test fails when I run it using Maven. In Eclipse (also with
IBM JDK 1.6) it does not fail.
Have a look at the test code:
========== %< =============
OptionGroup group = new OptionGroup();
group.addOption(OptionBuilder.create("a"));
group.addOption(OptionBuilder.create("b"));
group.addOption(OptionBuilder.create("c"));
Options options = new Options();
options.addOptionGroup(group);
StringWriter out = new StringWriter();
HelpFormatter formatter = new HelpFormatter();
formatter.printUsage(new PrintWriter(out), 80, "app", options);
System.out.println(out.toString());
assertEquals("usage: app [-a | -b | -c]" + EOL, out.toString());
========== %< =============
I have no idea, what causes the combo Maven/IBM JDK 6 to render a String
of "usage: app [-a <arg>| -b | -c]" here. It simply does not make sence,
but it is reproducible on every run.
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of CLI 1.2 RC3
Posted by Henri Yandell <fl...@gmail.com>.
Are these new errors Jörg, or do they happen with 1.1?
On Fri, Feb 27, 2009 at 6:17 PM, Jörg Schaible <jo...@gmx.de> wrote:
> Hi Henri,
>
> with RC3 I have the same test failures as with RC2:
> http://markmail.org/message/e6awtbsw4ypur2ru
>
> - Jörg
>
>
> Henri Yandell wrote:
>
>> Gary's regression bug is fixed. So voting again.
>>
>>
>> Tag:
>>
>> https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3
>>
>> Site remains unchanged:
>>
>> http://people.apache.org/~bayard/cli-1.2-rc1
>>
>> Binaries:
>>
>>
> http://people.apache.org/builds/commons/cli/1.2/RC3/staged/commons-cli/commons-cli/1.2/
>>
>> [ ] +1 release it
>> [ ] +0 go ahead I don't care
>> [ ] -1 no, do not release it because
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of CLI 1.2 RC3
Posted by Jörg Schaible <jo...@gmx.de>.
Hi Henri,
with RC3 I have the same test failures as with RC2:
http://markmail.org/message/e6awtbsw4ypur2ru
- Jörg
Henri Yandell wrote:
> Gary's regression bug is fixed. So voting again.
>
>
> Tag:
>
> https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3
>
> Site remains unchanged:
>
> http://people.apache.org/~bayard/cli-1.2-rc1
>
> Binaries:
>
>
http://people.apache.org/builds/commons/cli/1.2/RC3/staged/commons-cli/commons-cli/1.2/
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of CLI 1.2 RC3
Posted by Oliver Heger <ol...@oliver-heger.de>.
Henri Yandell schrieb:
> Something to fix - but I don't think this is a blocker on release. The
> only difference I can see is the extra newline at the end of one case
> and not the other, which is cosmetic as far as a user is concerned.
I created an issue [1] and attached a patch that fixes the problem by
using the OS-specific line terminator in the tests.
I think, this should be added for the release because it would be a
shame if one cannot build the source distribution under windows.
Oliver
[1] https://issues.apache.org/jira/browse/CLI-175
>
> On Fri, Feb 27, 2009 at 12:10 PM, Oliver Heger
> <ol...@oliver-heger.de> wrote:
>> I tried to build from the sources on Windows Vista with JDK 1.6 and got the
>> following test errors:
>>
>> Failed tests:
>> testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test)
>> testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test)
>>
>> Tests run: 186, Failures: 2, Errors: 0, Skipped: 0
>>
>> Below are the surefire reports I get.
>>
>> Oliver
>>
>> -------------------------------------------------------------------------------
>> Test set: org.apache.commons.cli.bug.BugCLI162Test
>> -------------------------------------------------------------------------------
>> Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec
>> <<< FAILURE!
>> testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test) Time
>> elapsed: 0.015 sec <<< FAILURE!
>> junit.framework.ComparisonFailure: Long arguments did not split as expected
>> expected:<...
>> org.apache.commons.cli.bug.B
>> ugCLI162Test
>> Header
>> -x,--extralongarg This
>> description
>> has
>> ReallyLongVal
>> uesThatAreLon
>> gerThanTheWid
>> thOfTheColumn
>> s and also
>> other
>> ReallyLongVal
>> uesThatAreHug
>> erAndBiggerTh
>> anTheWidthOfT
>> heColumnsBob,
>> yes.
>> Footer...> but was:<...
>> org.apache.commons.cli.bug.B
>> ugCLI162Test
>> Header
>> -x,--extralongarg This
>> description
>> has
>> ReallyLongVal
>> uesThatAreLon
>> gerThanTheWid
>> thOfTheColumn
>> s and also
>> other
>> ReallyLongVal
>> uesThatAreHug
>> erAndBiggerTh
>> anTheWidthOfT
>> heColumnsBob,
>> yes.
>> Footer
>> ...>
>> at junit.framework.Assert.assertEquals(Assert.java:81)
>> at
>> org.apache.commons.cli.bug.BugCLI162Test.testLongLineChunking(BugCLI162Test.java:261)
>>
>> testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test)
>> Time elapsed: 0 sec <<< FAILURE!
>> junit.framework.ComparisonFailure: Long arguments did not split as expected
>> expected:<...
>> org.apache.comm
>> ons.cli.bug.Bug
>> CLI162Test
>> Header
>> -x,--extralongarg
>> This description is
>> Long.
>> Footer...> but was:<...
>> org.apache.comm
>> ons.cli.bug.Bug
>> CLI162Test
>> Header
>> -x,--extralongarg
>> This description is
>> Long.
>> Footer
>> ...>
>> at junit.framework.Assert.assertEquals(Assert.java:81)
>> at
>> org.apache.commons.cli.bug.BugCLI162Test.testLongLineChunkingIndentIgnored(BugCLI162Test.java:280)
>>
>>
>>
>> Henri Yandell schrieb:
>>> Gary's regression bug is fixed. So voting again.
>>>
>>>
>>> Tag:
>>>
>>> https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3
>>>
>>> Site remains unchanged:
>>>
>>> http://people.apache.org/~bayard/cli-1.2-rc1
>>>
>>> Binaries:
>>>
>>>
>>> http://people.apache.org/builds/commons/cli/1.2/RC3/staged/commons-cli/commons-cli/1.2/
>>>
>>> [ ] +1 release it
>>> [ ] +0 go ahead I don't care
>>> [ ] -1 no, do not release it because
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of CLI 1.2 RC3
Posted by Henri Yandell <fl...@gmail.com>.
Something to fix - but I don't think this is a blocker on release. The
only difference I can see is the extra newline at the end of one case
and not the other, which is cosmetic as far as a user is concerned.
On Fri, Feb 27, 2009 at 12:10 PM, Oliver Heger
<ol...@oliver-heger.de> wrote:
> I tried to build from the sources on Windows Vista with JDK 1.6 and got the
> following test errors:
>
> Failed tests:
> testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test)
> testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test)
>
> Tests run: 186, Failures: 2, Errors: 0, Skipped: 0
>
> Below are the surefire reports I get.
>
> Oliver
>
> -------------------------------------------------------------------------------
> Test set: org.apache.commons.cli.bug.BugCLI162Test
> -------------------------------------------------------------------------------
> Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec
> <<< FAILURE!
> testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test) Time
> elapsed: 0.015 sec <<< FAILURE!
> junit.framework.ComparisonFailure: Long arguments did not split as expected
> expected:<...
> org.apache.commons.cli.bug.B
> ugCLI162Test
> Header
> -x,--extralongarg This
> description
> has
> ReallyLongVal
> uesThatAreLon
> gerThanTheWid
> thOfTheColumn
> s and also
> other
> ReallyLongVal
> uesThatAreHug
> erAndBiggerTh
> anTheWidthOfT
> heColumnsBob,
> yes.
> Footer...> but was:<...
> org.apache.commons.cli.bug.B
> ugCLI162Test
> Header
> -x,--extralongarg This
> description
> has
> ReallyLongVal
> uesThatAreLon
> gerThanTheWid
> thOfTheColumn
> s and also
> other
> ReallyLongVal
> uesThatAreHug
> erAndBiggerTh
> anTheWidthOfT
> heColumnsBob,
> yes.
> Footer
> ...>
> at junit.framework.Assert.assertEquals(Assert.java:81)
> at
> org.apache.commons.cli.bug.BugCLI162Test.testLongLineChunking(BugCLI162Test.java:261)
>
> testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test)
> Time elapsed: 0 sec <<< FAILURE!
> junit.framework.ComparisonFailure: Long arguments did not split as expected
> expected:<...
> org.apache.comm
> ons.cli.bug.Bug
> CLI162Test
> Header
> -x,--extralongarg
> This description is
> Long.
> Footer...> but was:<...
> org.apache.comm
> ons.cli.bug.Bug
> CLI162Test
> Header
> -x,--extralongarg
> This description is
> Long.
> Footer
> ...>
> at junit.framework.Assert.assertEquals(Assert.java:81)
> at
> org.apache.commons.cli.bug.BugCLI162Test.testLongLineChunkingIndentIgnored(BugCLI162Test.java:280)
>
>
>
> Henri Yandell schrieb:
>>
>> Gary's regression bug is fixed. So voting again.
>>
>>
>> Tag:
>>
>> https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3
>>
>> Site remains unchanged:
>>
>> http://people.apache.org/~bayard/cli-1.2-rc1
>>
>> Binaries:
>>
>>
>> http://people.apache.org/builds/commons/cli/1.2/RC3/staged/commons-cli/commons-cli/1.2/
>>
>> [ ] +1 release it
>> [ ] +0 go ahead I don't care
>> [ ] -1 no, do not release it because
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of CLI 1.2 RC3
Posted by Henri Yandell <fl...@gmail.com>.
Random guess - the PrintWriter API is putting platform specific stuff
in for \n, so the StringWriter is not the same while on Windows.
On Fri, Feb 27, 2009 at 12:10 PM, Oliver Heger
<ol...@oliver-heger.de> wrote:
> I tried to build from the sources on Windows Vista with JDK 1.6 and got the
> following test errors:
>
> Failed tests:
> testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test)
> testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test)
>
> Tests run: 186, Failures: 2, Errors: 0, Skipped: 0
>
> Below are the surefire reports I get.
>
> Oliver
>
> -------------------------------------------------------------------------------
> Test set: org.apache.commons.cli.bug.BugCLI162Test
> -------------------------------------------------------------------------------
> Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec
> <<< FAILURE!
> testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test) Time
> elapsed: 0.015 sec <<< FAILURE!
> junit.framework.ComparisonFailure: Long arguments did not split as expected
> expected:<...
> org.apache.commons.cli.bug.B
> ugCLI162Test
> Header
> -x,--extralongarg This
> description
> has
> ReallyLongVal
> uesThatAreLon
> gerThanTheWid
> thOfTheColumn
> s and also
> other
> ReallyLongVal
> uesThatAreHug
> erAndBiggerTh
> anTheWidthOfT
> heColumnsBob,
> yes.
> Footer...> but was:<...
> org.apache.commons.cli.bug.B
> ugCLI162Test
> Header
> -x,--extralongarg This
> description
> has
> ReallyLongVal
> uesThatAreLon
> gerThanTheWid
> thOfTheColumn
> s and also
> other
> ReallyLongVal
> uesThatAreHug
> erAndBiggerTh
> anTheWidthOfT
> heColumnsBob,
> yes.
> Footer
> ...>
> at junit.framework.Assert.assertEquals(Assert.java:81)
> at
> org.apache.commons.cli.bug.BugCLI162Test.testLongLineChunking(BugCLI162Test.java:261)
>
> testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test)
> Time elapsed: 0 sec <<< FAILURE!
> junit.framework.ComparisonFailure: Long arguments did not split as expected
> expected:<...
> org.apache.comm
> ons.cli.bug.Bug
> CLI162Test
> Header
> -x,--extralongarg
> This description is
> Long.
> Footer...> but was:<...
> org.apache.comm
> ons.cli.bug.Bug
> CLI162Test
> Header
> -x,--extralongarg
> This description is
> Long.
> Footer
> ...>
> at junit.framework.Assert.assertEquals(Assert.java:81)
> at
> org.apache.commons.cli.bug.BugCLI162Test.testLongLineChunkingIndentIgnored(BugCLI162Test.java:280)
>
>
>
> Henri Yandell schrieb:
>>
>> Gary's regression bug is fixed. So voting again.
>>
>>
>> Tag:
>>
>> https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3
>>
>> Site remains unchanged:
>>
>> http://people.apache.org/~bayard/cli-1.2-rc1
>>
>> Binaries:
>>
>>
>> http://people.apache.org/builds/commons/cli/1.2/RC3/staged/commons-cli/commons-cli/1.2/
>>
>> [ ] +1 release it
>> [ ] +0 go ahead I don't care
>> [ ] -1 no, do not release it because
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release of CLI 1.2 RC3
Posted by Oliver Heger <ol...@oliver-heger.de>.
I tried to build from the sources on Windows Vista with JDK 1.6 and got
the following test errors:
Failed tests:
testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test)
testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test)
Tests run: 186, Failures: 2, Errors: 0, Skipped: 0
Below are the surefire reports I get.
Oliver
-------------------------------------------------------------------------------
Test set: org.apache.commons.cli.bug.BugCLI162Test
-------------------------------------------------------------------------------
Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.031
sec <<< FAILURE!
testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test) Time
elapsed: 0.015 sec <<< FAILURE!
junit.framework.ComparisonFailure: Long arguments did not split as
expected expected:<...
org.apache.commons.cli.bug.B
ugCLI162Test
Header
-x,--extralongarg This
description
has
ReallyLongVal
uesThatAreLon
gerThanTheWid
thOfTheColumn
s and also
other
ReallyLongVal
uesThatAreHug
erAndBiggerTh
anTheWidthOfT
heColumnsBob,
yes.
Footer...> but was:<...
org.apache.commons.cli.bug.B
ugCLI162Test
Header
-x,--extralongarg This
description
has
ReallyLongVal
uesThatAreLon
gerThanTheWid
thOfTheColumn
s and also
other
ReallyLongVal
uesThatAreHug
erAndBiggerTh
anTheWidthOfT
heColumnsBob,
yes.
Footer
...>
at junit.framework.Assert.assertEquals(Assert.java:81)
at
org.apache.commons.cli.bug.BugCLI162Test.testLongLineChunking(BugCLI162Test.java:261)
testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test)
Time elapsed: 0 sec <<< FAILURE!
junit.framework.ComparisonFailure: Long arguments did not split as
expected expected:<...
org.apache.comm
ons.cli.bug.Bug
CLI162Test
Header
-x,--extralongarg
This description is
Long.
Footer...> but was:<...
org.apache.comm
ons.cli.bug.Bug
CLI162Test
Header
-x,--extralongarg
This description is
Long.
Footer
...>
at junit.framework.Assert.assertEquals(Assert.java:81)
at
org.apache.commons.cli.bug.BugCLI162Test.testLongLineChunkingIndentIgnored(BugCLI162Test.java:280)
Henri Yandell schrieb:
> Gary's regression bug is fixed. So voting again.
>
>
> Tag:
>
> https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3
>
> Site remains unchanged:
>
> http://people.apache.org/~bayard/cli-1.2-rc1
>
> Binaries:
>
> http://people.apache.org/builds/commons/cli/1.2/RC3/staged/commons-cli/commons-cli/1.2/
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org