You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/28 18:16:50 UTC
[GitHub] [echarts] MeetzhDing opened a new pull request, #16963: fix(scale): intervalTick should between extent. close 16888
MeetzhDing opened a new pull request, #16963:
URL: https://github.com/apache/echarts/pull/16963
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
filter intervalTick by `tick.value > extent[0] && tick.value < extent[1] && !tick.notAdd;`
### Fixed issues
xAxis[type=time], set showMinLabel=false not work
## Details
### Before: What was the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #16963: fix(scale): intervalTick should between extent. close 16888
Posted by GitBox <gi...@apache.org>.
pissang commented on PR #16963:
URL: https://github.com/apache/echarts/pull/16963#issuecomment-1112840711
Thanks! Could you add a test case for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] MeetzhDing commented on pull request #16963: fix(scale): intervalTick should between extent. close 16888
Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on PR #16963:
URL: https://github.com/apache/echarts/pull/16963#issuecomment-1112854177
> Thanks! Could you add a test case for this?
done.
<img width="1972" alt="image" src="https://user-images.githubusercontent.com/12808432/165883332-ec089fc7-5d6c-4c86-86e6-d64118188cc1.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16963: fix(scale): intervalTick should between extent. close 16888
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #16963:
URL: https://github.com/apache/echarts/pull/16963#issuecomment-1112520072
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] MeetzhDing commented on a diff in pull request #16963: fix(scale): intervalTick should between extent. close 16888
Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on code in PR #16963:
URL: https://github.com/apache/echarts/pull/16963#discussion_r940908096
##########
test/axisLabel.html:
##########
@@ -267,7 +268,7 @@
option = {
backgroundColor: '#eee',
title: {
- text: 'axisLable.formatter: {value} should be correct'
+ text: 'axisLabel.formatter: {value} should be correct'
Review Comment:
related test case has been move into timeScale-formaatter.html
@Ovilia
##########
src/scale/Time.ts:
##########
@@ -628,7 +628,7 @@ function getIntervalTicks(
}
const levelsTicksInExtent = filter(map(levelsTicks, levelTicks => {
- return filter(levelTicks, tick => tick.value >= extent[0] && tick.value <= extent[1] && !tick.notAdd);
+ return filter(levelTicks, tick => tick.value > extent[0] && tick.value < extent[1] && !tick.notAdd);
Review Comment:
> This is probably not the correct place to fix the problem. For example, the min/max labels are always hidden after this changing. You need to make sure the test cases in `timeScale-formatter.html` still works the same as before changing.
min/max labels work normal after this changing, could you check it again? Or give me a specific example ?
@Ovilia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] MeetzhDing commented on a diff in pull request #16963: fix(scale): intervalTick should between extent. close 16888
Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on code in PR #16963:
URL: https://github.com/apache/echarts/pull/16963#discussion_r940907692
##########
src/scale/Time.ts:
##########
@@ -628,7 +628,7 @@ function getIntervalTicks(
}
const levelsTicksInExtent = filter(map(levelsTicks, levelTicks => {
- return filter(levelTicks, tick => tick.value >= extent[0] && tick.value <= extent[1] && !tick.notAdd);
+ return filter(levelTicks, tick => tick.value > extent[0] && tick.value < extent[1] && !tick.notAdd);
Review Comment:
> This is probably not the correct place to fix the problem. For example, the min/max labels are always hidden after this changing. You need to make sure the test cases in `timeScale-formatter.html` still works the same as before changing.
min/max labels work normal afeer this changing, could you check it again? Or give me a specific example ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(scale): intervalTick should between extent. close 16888 [echarts]
Posted by "leoclo (via GitHub)" <gi...@apache.org>.
leoclo commented on PR #16963:
URL: https://github.com/apache/echarts/pull/16963#issuecomment-1992888834
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] MeetzhDing commented on a diff in pull request #16963: fix(scale): intervalTick should between extent. close 16888
Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on code in PR #16963:
URL: https://github.com/apache/echarts/pull/16963#discussion_r940908096
##########
test/axisLabel.html:
##########
@@ -267,7 +268,7 @@
option = {
backgroundColor: '#eee',
title: {
- text: 'axisLable.formatter: {value} should be correct'
+ text: 'axisLabel.formatter: {value} should be correct'
Review Comment:
related test case has been move into timeScale-formaatter.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] MeetzhDing commented on pull request #16963: fix(scale): intervalTick should between extent. close 16888
Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on PR #16963:
URL: https://github.com/apache/echarts/pull/16963#issuecomment-1219288959
min/max labels work normal after this changing, could you check it again? Or give me a specific example ?
@Ovilia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] MeetzhDing commented on a diff in pull request #16963: fix(scale): intervalTick should between extent. close 16888
Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on code in PR #16963:
URL: https://github.com/apache/echarts/pull/16963#discussion_r940907692
##########
src/scale/Time.ts:
##########
@@ -628,7 +628,7 @@ function getIntervalTicks(
}
const levelsTicksInExtent = filter(map(levelsTicks, levelTicks => {
- return filter(levelTicks, tick => tick.value >= extent[0] && tick.value <= extent[1] && !tick.notAdd);
+ return filter(levelTicks, tick => tick.value > extent[0] && tick.value < extent[1] && !tick.notAdd);
Review Comment:
> This is probably not the correct place to fix the problem. For example, the min/max labels are always hidden after this changing. You need to make sure the test cases in `timeScale-formatter.html` still works the same as before changing.
min/max labels work normal after this changing, could you check it again? Or give me a specific example ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] MeetzhDing commented on pull request #16963: fix(scale): intervalTick should between extent. close 16888
Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on PR #16963:
URL: https://github.com/apache/echarts/pull/16963#issuecomment-1263061942
min/max labels work normal after this changing, could you check it again? Or give me a specific example ?
@Ovilia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on a diff in pull request #16963: fix(scale): intervalTick should between extent. close 16888
Posted by GitBox <gi...@apache.org>.
Ovilia commented on code in PR #16963:
URL: https://github.com/apache/echarts/pull/16963#discussion_r890818337
##########
src/scale/Time.ts:
##########
@@ -628,7 +628,7 @@ function getIntervalTicks(
}
const levelsTicksInExtent = filter(map(levelsTicks, levelTicks => {
- return filter(levelTicks, tick => tick.value >= extent[0] && tick.value <= extent[1] && !tick.notAdd);
+ return filter(levelTicks, tick => tick.value > extent[0] && tick.value < extent[1] && !tick.notAdd);
Review Comment:
This is probably not the correct place to fix the problem. For example, the min/max labels are always hidden after this changing. You need to make sure the test cases in `timeScale-formatter.html` still works the same as before changing.
##########
test/axisLabel.html:
##########
@@ -267,7 +268,7 @@
option = {
backgroundColor: '#eee',
title: {
- text: 'axisLable.formatter: {value} should be correct'
+ text: 'axisLabel.formatter: {value} should be correct'
Review Comment:
Related test cases should be put into `timeScale-formatter.html`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org