[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #11257: [improvement]Use phmap::flat_hash_set in AggregateFunctionUniq

[GitBox <gi...@apache.org>]

BiteTheDDDDt commented on code in PR #11257:
URL: https://github.com/apache/doris/pull/11257#discussion_r930867953


##########
be/src/vec/aggregate_functions/aggregate_function.h:
##########
@@ -224,6 +228,9 @@ class IAggregateFunctionHelper : public IAggregateFunction {
                                                      arena);
         }
     }
+
+    virtual void deserialize_and_merge(AggregateDataPtr __restrict place, BufferReadable& buf,
+                                       Arena* arena) const override {}

Review Comment:
   Does we need add some check at here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org