You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/04 02:54:34 UTC
[GitHub] [pulsar] Huanli-Meng opened a new pull request #7162: [Issue 2793][Doc]--Update the TLS hostname verification for CPP and Python clients
Huanli-Meng opened a new pull request #7162:
URL: https://github.com/apache/pulsar/pull/7162
Main updates:
1: update the TLS hostname verification code example for C++ and Python clients.
2: fix link errors.
3: arrange doc heading levels.
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<2793>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (docs)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #7162: [Issue 2793][Doc]--Update the TLS hostname verification for CPP and Python clients
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #7162:
URL: https://github.com/apache/pulsar/pull/7162#discussion_r435228197
##########
File path: site2/docs/security-tls-transport.md
##########
@@ -207,30 +207,31 @@ PulsarClient client = PulsarClient.builder()
.build();
```
-### Python client
+#### Python client
```python
from pulsar import Client
client = Client("pulsar+ssl://broker.example.com:6651/",
+ tls_hostname_verification=True,
tls_trust_certs_file_path="/path/to/ca.cert.pem",
tls_allow_insecure_connection=False) // defaults to false from v2.2.0 onwards
```
-### C++ client
+#### C++ client
```c++
#include <pulsar/Client.h>
-pulsar::ClientConfiguration config;
-config.setUseTls(true);
-config.setTlsTrustCertsFilePath("/path/to/ca.cert.pem");
-config.setTlsAllowInsecureConnection(false); // defaults to false from v2.2.0 onwards
-
-pulsar::Client client("pulsar+ssl://broker.example.com:6651/", config);
+ClientConfiguration config = ClientConfiguration();
+ config.setUseTls(true); // shouldn't be needed soon
Review comment:
please remove the blanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on pull request #7162: [Issue 2793][Doc]--Update the TLS hostname verification for CPP and Python clients
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on pull request #7162:
URL: https://github.com/apache/pulsar/pull/7162#issuecomment-638572167
doc is updated for the master currently. after it is reviewed and approved, will update it to previous releases (until 2.3.0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on pull request #7162: [Issue 2793][Doc]--Update the TLS hostname verification for CPP and Python clients
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on pull request #7162:
URL: https://github.com/apache/pulsar/pull/7162#issuecomment-638834120
@jiazhai , doc is updated. please help double check. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7162: [Issue 2793][Doc]--Update the TLS hostname verification for CPP and Python clients
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7162:
URL: https://github.com/apache/pulsar/pull/7162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org