You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "C. Jason Benedict" <jb...@Q4i.com> on 2000/08/07 18:23:38 UTC
Attention Owner of [XmlMapper.java]!!!
I posted this last Thursday and have not heard anything back on it, if someone could please give a status. This should be included in 3.2 final.
"C. Jason Benedict" wrote:
> Whoever is responsible for this piece of code, please review and implement my change to detect 'null' Strings before continuing through the process. This will fix the problem with reading external entities in the web.xml file.
>
> subliminal 59 - cojakarta diff -lN
>
> ? .XmlMapper.java
>
> cvs server: Diffing .
>
> Index: XmlMapper.java
>
> ===================================================================
>
> RCS file: /home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/util/xml/XmlMapper.java,v
>
> retrieving revision 1.26
>
> diff -r1.26 XmlMapper.java
>
> 406,408c406,417
>
> < public InputSource resolveEntity(String publicId, String systemId)
>
> < throws SAXException
>
> < {
>
> ---
>
> > public InputSource resolveEntity(String publicId, String systemId) throws SAXException {
>
> >
>
> > if(publicId == null) {
>
> > log("publicID is 'null'");
>
> > return null;
>
> > }
>
> >
>
> > if(systemId == null) {
>
> > log("systemId is 'null'");
>
> > return null;
>
> > }
>
> >
>
> --
>
> C. Jason Benedict
--
C. Jason Benedict
Re: XmlMapper.java [Att. SAM]
Posted by "C. Jason Benedict" <jb...@Q4i.com>.
Sam,
can you help get this patch into csv for tomcat before the 3.2 final?
Costin Manolache wrote:
> I'm sorry for answering so late, but I do have a job and I had a lot of work to do. I hope to find some time for tomcat later this week. The patch is great and should go into 3.2 final - if Sam agrees.
>
> I don't think XmlMapper has any "owner" - I wrote (some of ) the code, but it's owned by the whole group.
>
> If any comiter has some time please check in this patch - and few others that were submitted last week. If nobody has time - probably we need to add more comiters or find a better way to get the patches and code in.
>
> Costin
>
> "C. Jason Benedict" wrote:
>
> > I posted this last Thursday and have not heard anything back on it, if someone could please give a status. This should be included in 3.2 final.
> >
> > "C. Jason Benedict" wrote:
> >
> > > Whoever is responsible for this piece of code, please review and implement my change to detect 'null' Strings before continuing through the process. This will fix the problem with reading external entities in the web.xml file.
> > >
> > > subliminal 59 - cojakarta diff -lN
> > >
> > > ? .XmlMapper.java
> > >
> > > cvs server: Diffing .
> > >
> > > Index: XmlMapper.java
> > >
> > > ===================================================================
> > >
> > > RCS file: /home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/util/xml/XmlMapper.java,v
> > >
> > > retrieving revision 1.26
> > >
> > > diff -r1.26 XmlMapper.java
> > >
> > > 406,408c406,417
> > >
> > > < public InputSource resolveEntity(String publicId, String systemId)
> > >
> > > < throws SAXException
> > >
> > > < {
> > >
> > > ---
> > >
> > > > public InputSource resolveEntity(String publicId, String systemId) throws SAXException {
> > >
> > > >
> > >
> > > > if(publicId == null) {
> > >
> > > > log("publicID is 'null'");
> > >
> > > > return null;
> > >
> > > > }
> > >
> > > >
> > >
> > > > if(systemId == null) {
> > >
> > > > log("systemId is 'null'");
> > >
> > > > return null;
> > >
> > > > }
> > >
> > > >
> > >
> > > --
> > >
> > > C. Jason Benedict
> >
> > --
> >
> > C. Jason Benedict
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
--
C. Jason Benedict
Re: Attention Owner of [XmlMapper.java]!!!
Posted by Costin Manolache <cm...@yahoo.com>.
I'm sorry for answering so late, but I do have a job and I had a lot of work to do. I hope to find some time for tomcat later this week. The patch is great and should go into 3.2 final - if Sam agrees.
I don't think XmlMapper has any "owner" - I wrote (some of ) the code, but it's owned by the whole group.
If any comiter has some time please check in this patch - and few others that were submitted last week. If nobody has time - probably we need to add more comiters or find a better way to get the patches and code in.
Costin
"C. Jason Benedict" wrote:
> I posted this last Thursday and have not heard anything back on it, if someone could please give a status. This should be included in 3.2 final.
>
> "C. Jason Benedict" wrote:
>
> > Whoever is responsible for this piece of code, please review and implement my change to detect 'null' Strings before continuing through the process. This will fix the problem with reading external entities in the web.xml file.
> >
> > subliminal 59 - cojakarta diff -lN
> >
> > ? .XmlMapper.java
> >
> > cvs server: Diffing .
> >
> > Index: XmlMapper.java
> >
> > ===================================================================
> >
> > RCS file: /home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/util/xml/XmlMapper.java,v
> >
> > retrieving revision 1.26
> >
> > diff -r1.26 XmlMapper.java
> >
> > 406,408c406,417
> >
> > < public InputSource resolveEntity(String publicId, String systemId)
> >
> > < throws SAXException
> >
> > < {
> >
> > ---
> >
> > > public InputSource resolveEntity(String publicId, String systemId) throws SAXException {
> >
> > >
> >
> > > if(publicId == null) {
> >
> > > log("publicID is 'null'");
> >
> > > return null;
> >
> > > }
> >
> > >
> >
> > > if(systemId == null) {
> >
> > > log("systemId is 'null'");
> >
> > > return null;
> >
> > > }
> >
> > >
> >
> > --
> >
> > C. Jason Benedict
>
> --
>
> C. Jason Benedict
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org