[GitHub] suez1224 commented on a change in pull request #7356: [FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers

[GitBox <gi...@apache.org>]

suez1224 commented on a change in pull request #7356: [FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers
URL: https://github.com/apache/flink/pull/7356#discussion_r251657123
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
 ##########
 @@ -83,8 +83,27 @@
 	 */
 	public static final ConfigOption<String> MAX_FAILED_CONTAINERS =
 		key("yarn.maximum-failed-containers")
-		.noDefaultValue()
-		.withDescription("Maximum number of containers the system is going to reallocate in case of a failure.");
+			.noDefaultValue()
+			.withDescription("Maximum number of containers the system is going to reallocate in case of a failure.");
+
+	/**
+	 * The maximum number of failed YARN containers within an interval before entirely stopping
+	 * the YARN session / job on YARN.
+	 * By default, the value is -1
+	 */
+	public static final ConfigOption<Integer> MAX_FAILED_CONTAINERS_PER_INTERVAL =
+		key("yarn.maximum-failed-containers-per-interval")
+		.defaultValue(-1)
+		.withDescription("Maximum number of containers the system is going to reallocate in case of a failure in an interval.");
+
+	/**
+	 * The interval for measuring failure rate of containers in second unit.
+	 * By default, the value is 5 minutes.
+	 **/
+	public static final ConfigOption<Integer> CONTAINERS_FAILURE_RATE_INTERVAL =
+		key("yarn.containers-failure-rate-interval")
+		.defaultValue(300)
+		.withDeprecatedKeys("The interval for measuring failure rate of containers");
 
 Review comment:
   Should be withDescription here, not withDeprecatedKeys.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services