You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rampart-dev@ws.apache.org by "Vy Ho (JIRA)" <ji...@apache.org> on 2010/03/01 02:10:05 UTC

[jira] Created: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Ant task Java2WSDLTask does not allow the use of extraClasses
-------------------------------------------------------------

                 Key: AXIS2-4634
                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
             Project: Axis2
          Issue Type: Bug
          Components: Tools
    Affects Versions: 1.5.1
         Environment: OpenSuse 11.2, JDK 1.6
            Reporter: Vy Ho
             Fix For: 1.5.1


The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.

I fixed this by changing the String [] to String for extraClasses

And the setter and getter accordingly.

I also change the addToOptionMap entry:

        addToOptionMap(optionMap,
                Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
                getMultiStringArray(getExtraClasses()));

Basically, I parse the extraClasses string (comma delimited).

The method getMultiStringArray is just extraClasses.split(",")





-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment: Item.java
                ExtraClasses.java
                Java2WSDLTask.diff

Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>



> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment:     (was: Java2WSDLTask.diff)

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Issue Comment Edited: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842685#action_12842685 ] 

Vy Ho edited comment on AXIS2-4634 at 3/8/10 2:59 PM:
------------------------------------------------------

Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>

Please update the user manual/guide before closing this bug.



      was (Author: hovh03@yahoo.com):
    Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>


  
> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839881#action_12839881 ] 

Andreas Veithen commented on AXIS2-4634:
----------------------------------------

Confirmed. I'm not an Ant expert, but using a String[] attribute directly indeed doesn't seem to be possible. Unfortunately the person who submitted that code (see AXIS2-1411) is no longer around to explain how this was supposed to work.

Instead of using a custom comma separated syntax, I would prefer nested elements [1]. This would be nicer, especially because a list of class names can quickly become very long. What do you think?

[1] http://ant.apache.org/manual/tutorial-writing-tasks.html#NestedElements

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840238#action_12840238 ] 

Andreas Veithen commented on AXIS2-4634:
----------------------------------------

Supporting both methods is probably the best idea. Can you submit a new patch that also implements the nested element?

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Assigned: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen reassigned AXIS2-4634:
--------------------------------------

    Assignee: Andreas Veithen

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Resolved: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved AXIS2-4634.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.5.1)
                   1.6

Implemented the change, but with a slightly different syntax than the one proposed above (<extraclass> as direct child of the task + Ant favors attributes over text nodes). See the antrun configuration in [1] for examples.

[1] http://svn.apache.org/repos/asf/axis/axis2/java/core/trunk/modules/tool/axis2-ant-plugin/pom.xml

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>             Fix For: 1.6
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment:     (was: Java2WSDLTask.diff)

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Resolved: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved AXIS2-4634.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.5.1)
                   1.6

Implemented the change, but with a slightly different syntax than the one proposed above (<extraclass> as direct child of the task + Ant favors attributes over text nodes). See the antrun configuration in [1] for examples.

[1] http://svn.apache.org/repos/asf/axis/axis2/java/core/trunk/modules/tool/axis2-ant-plugin/pom.xml

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>             Fix For: 1.6
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840238#action_12840238 ] 

Andreas Veithen commented on AXIS2-4634:
----------------------------------------

Supporting both methods is probably the best idea. Can you submit a new patch that also implements the nested element?

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment: Item.java
                ExtraClasses.java
                Java2WSDLTask.diff

Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>



> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment: Java2WSDLTask.diff

This is a diff of a fix that I put in to resolve this issue.

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839996#action_12839996 ] 

Vy Ho commented on AXIS2-4634:
------------------------------

There are pros and cons to both method.  For a single field (comma separated), the string can be created somewhere, and passed into this in a generic way.  So the task is created and reuse again every time it's needed else where (for a large project type).
For a sub element, it's much clearer and not long.  Maybe allowing both?

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment: Java2WSDLTask.diff

This is a diff of a fix that I put in to resolve this issue.

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment:     (was: Java2WSDLTask.diff)

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839996#action_12839996 ] 

Vy Ho commented on AXIS2-4634:
------------------------------

There are pros and cons to both method.  For a single field (comma separated), the string can be created somewhere, and passed into this in a generic way.  So the task is created and reuse again every time it's needed else where (for a large project type).
For a sub element, it's much clearer and not long.  Maybe allowing both?

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Issue Comment Edited: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842685#action_12842685 ] 

Vy Ho edited comment on AXIS2-4634 at 3/8/10 2:59 PM:
------------------------------------------------------

Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>

Please update the user manual/guide before closing this bug.



      was (Author: hovh03@yahoo.com):
    Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>


  
> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840238#action_12840238 ] 

Andreas Veithen commented on AXIS2-4634:
----------------------------------------

Supporting both methods is probably the best idea. Can you submit a new patch that also implements the nested element?

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839881#action_12839881 ] 

Andreas Veithen commented on AXIS2-4634:
----------------------------------------

Confirmed. I'm not an Ant expert, but using a String[] attribute directly indeed doesn't seem to be possible. Unfortunately the person who submitted that code (see AXIS2-1411) is no longer around to explain how this was supposed to work.

Instead of using a custom comma separated syntax, I would prefer nested elements [1]. This would be nicer, especially because a list of class names can quickly become very long. What do you think?

[1] http://ant.apache.org/manual/tutorial-writing-tasks.html#NestedElements

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840238#action_12840238 ] 

Andreas Veithen commented on AXIS2-4634:
----------------------------------------

Supporting both methods is probably the best idea. Can you submit a new patch that also implements the nested element?

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment: Item.java
                ExtraClasses.java
                Java2WSDLTask.diff

Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>



> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839881#action_12839881 ] 

Andreas Veithen commented on AXIS2-4634:
----------------------------------------

Confirmed. I'm not an Ant expert, but using a String[] attribute directly indeed doesn't seem to be possible. Unfortunately the person who submitted that code (see AXIS2-1411) is no longer around to explain how this was supposed to work.

Instead of using a custom comma separated syntax, I would prefer nested elements [1]. This would be nicer, especially because a list of class names can quickly become very long. What do you think?

[1] http://ant.apache.org/manual/tutorial-writing-tasks.html#NestedElements

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Resolved: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved AXIS2-4634.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.5.1)
                   1.6

Implemented the change, but with a slightly different syntax than the one proposed above (<extraclass> as direct child of the task + Ant favors attributes over text nodes). See the antrun configuration in [1] for examples.

[1] http://svn.apache.org/repos/asf/axis/axis2/java/core/trunk/modules/tool/axis2-ant-plugin/pom.xml

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>             Fix For: 1.6
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Assigned: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen reassigned AXIS2-4634:
--------------------------------------

    Assignee: Andreas Veithen

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Assigned: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen reassigned AXIS2-4634:
--------------------------------------

    Assignee: Andreas Veithen

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment: Item.java
                ExtraClasses.java
                Java2WSDLTask.diff

Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>



> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839996#action_12839996 ] 

Vy Ho commented on AXIS2-4634:
------------------------------

There are pros and cons to both method.  For a single field (comma separated), the string can be created somewhere, and passed into this in a generic way.  So the task is created and reuse again every time it's needed else where (for a large project type).
For a sub element, it's much clearer and not long.  Maybe allowing both?

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment: Item.java
                ExtraClasses.java
                Java2WSDLTask.diff

Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>



> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839881#action_12839881 ] 

Andreas Veithen commented on AXIS2-4634:
----------------------------------------

Confirmed. I'm not an Ant expert, but using a String[] attribute directly indeed doesn't seem to be possible. Unfortunately the person who submitted that code (see AXIS2-1411) is no longer around to explain how this was supposed to work.

Instead of using a custom comma separated syntax, I would prefer nested elements [1]. This would be nicer, especially because a list of class names can quickly become very long. What do you think?

[1] http://ant.apache.org/manual/tutorial-writing-tasks.html#NestedElements

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Assigned: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen reassigned AXIS2-4634:
--------------------------------------

    Assignee: Andreas Veithen

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment: Java2WSDLTask.diff

This is a diff of a fix that I put in to resolve this issue.

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment:     (was: Java2WSDLTask.diff)

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Resolved: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved AXIS2-4634.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.5.1)
                   1.6

Implemented the change, but with a slightly different syntax than the one proposed above (<extraclass> as direct child of the task + Ant favors attributes over text nodes). See the antrun configuration in [1] for examples.

[1] http://svn.apache.org/repos/asf/axis/axis2/java/core/trunk/modules/tool/axis2-ant-plugin/pom.xml

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>             Fix For: 1.6
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839996#action_12839996 ] 

Vy Ho commented on AXIS2-4634:
------------------------------

There are pros and cons to both method.  For a single field (comma separated), the string can be created somewhere, and passed into this in a generic way.  So the task is created and reuse again every time it's needed else where (for a large project type).
For a sub element, it's much clearer and not long.  Maybe allowing both?

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Issue Comment Edited: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842685#action_12842685 ] 

Vy Ho edited comment on AXIS2-4634 at 3/8/10 2:59 PM:
------------------------------------------------------

Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>

Please update the user manual/guide before closing this bug.



      was (Author: hovh03@yahoo.com):
    Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>


  
> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840238#action_12840238 ] 

Andreas Veithen commented on AXIS2-4634:
----------------------------------------

Supporting both methods is probably the best idea. Can you submit a new patch that also implements the nested element?

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839996#action_12839996 ] 

Vy Ho commented on AXIS2-4634:
------------------------------

There are pros and cons to both method.  For a single field (comma separated), the string can be created somewhere, and passed into this in a generic way.  So the task is created and reuse again every time it's needed else where (for a large project type).
For a sub element, it's much clearer and not long.  Maybe allowing both?

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment: Java2WSDLTask.diff

This is a diff of a fix that I put in to resolve this issue.

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment:     (was: Java2WSDLTask.diff)

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vy Ho updated AXIS2-4634:
-------------------------

    Attachment: Java2WSDLTask.diff

This is a diff of a fix that I put in to resolve this issue.

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Assigned: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen reassigned AXIS2-4634:
--------------------------------------

    Assignee: Andreas Veithen

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Resolved: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved AXIS2-4634.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.5.1)
                   1.6

Implemented the change, but with a slightly different syntax than the one proposed above (<extraclass> as direct child of the task + Ant favors attributes over text nodes). See the antrun configuration in [1] for examples.

[1] http://svn.apache.org/repos/asf/axis/axis2/java/core/trunk/modules/tool/axis2-ant-plugin/pom.xml

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>             Fix For: 1.6
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Issue Comment Edited: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842685#action_12842685 ] 

Vy Ho edited comment on AXIS2-4634 at 3/8/10 2:59 PM:
------------------------------------------------------

Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>

Please update the user manual/guide before closing this bug.



      was (Author: hovh03@yahoo.com):
    Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>


  
> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839881#action_12839881 ] 

Andreas Veithen commented on AXIS2-4634:
----------------------------------------

Confirmed. I'm not an Ant expert, but using a String[] attribute directly indeed doesn't seem to be possible. Unfortunately the person who submitted that code (see AXIS2-1411) is no longer around to explain how this was supposed to work.

Instead of using a custom comma separated syntax, I would prefer nested elements [1]. This would be nicer, especially because a list of class names can quickly become very long. What do you think?

[1] http://ant.apache.org/manual/tutorial-writing-tasks.html#NestedElements

> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Issue Comment Edited: (AXIS2-4634) Ant task Java2WSDLTask does not allow the use of extraClasses

Posted by "Vy Ho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842685#action_12842685 ] 

Vy Ho edited comment on AXIS2-4634 at 3/8/10 2:59 PM:
------------------------------------------------------

Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>

Please update the user manual/guide before closing this bug.



      was (Author: hovh03@yahoo.com):
    Patches to support extraClasses
- Now, it's possible to use either or both extraClasses attribute and ExtraClasses nested element
For extraClasses attribute, the fully qualified class names are separated by commas.
For ExtraClasses nested element, it has a list of further nested elements.  Each of elements in the list is either ExtraClass or XC tag.
This tag contains a fully qualified class name.
For example:

<java2wsdl ...>

<extraClasses>
    <ExtraClass>org.apache.Test</ExtraClass>
    <Xc>org.apache.Test2</Xc>
</extraClasses>
</java2wsdl>


  
> Ant task Java2WSDLTask does not allow the use of extraClasses
> -------------------------------------------------------------
>
>                 Key: AXIS2-4634
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4634
>             Project: Axis2
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDK 1.6
>            Reporter: Vy Ho
>             Fix For: 1.5.1
>
>         Attachments: ExtraClasses.java, Item.java, Java2WSDLTask.diff
>
>
> The ant task Java2WSDLTask doesn't allow setting the attribute extraClasses because it is an array type.
> I fixed this by changing the String [] to String for extraClasses
> And the setter and getter accordingly.
> I also change the addToOptionMap entry:
>         addToOptionMap(optionMap,
>                 Java2WSDLConstants.EXTRA_CLASSES_DEFAULT_OPTION,
>                 getMultiStringArray(getExtraClasses()));
> Basically, I parse the extraClasses string (comma delimited).
> The method getMultiStringArray is just extraClasses.split(",")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org