You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2020/04/08 04:25:24 UTC

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15685


Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................

WIP [docs] Kudu 1.12 release notes draft

WIP:
  * this is published just as working draft to iterate upon

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 57 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Lieber-Dembo, Grant Henke, Hannah Nguyen, Greg Solovyev, Volodymyr Verovkin, Bankim Bhavsar, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15685

to look at the new patch set (#8).

Change subject: [docs] add 1.12.0 release notes
......................................................................

[docs] add 1.12.0 release notes

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 201 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/8
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 10: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 10
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 21:15:38 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@58
PS2, Line 58: Kudu now offers a tool to quiesce tablet servers
"The `kudu tserver quiesce` tool is added to quiesce tablet servers."


http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@74
PS2, Line 74: kudu fs update_dirs
wrap in backticks


http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@75
PS2, Line 75: recovery
"recover"


http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@81
PS2, Line 81: maintenance
"maintenance operation"


http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@84
PS2, Line 84: certain workloads
"workloads that contained updates"



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 18:51:29 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hannah Nguyen, Volodymyr Verovkin, Bankim Bhavsar, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15685

to look at the new patch set (#5).

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................

WIP [docs] Kudu 1.12 release notes draft

WIP:
  * this is published just as working draft to iterate upon

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 122 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc
File docs/release_notes.adoc:

PS2: 
For PS2, I updated this document incorporating the following notes:

  https://gerrit.cloudera.org/#/c/15456/
  https://gerrit.cloudera.org/#/c/15594/



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Apr 2020 04:47:56 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@56
PS5, Line 56: == New features
> Should add a note about columnar return type.
I am not sure we want to add a note about columnar given it's experimental and only available in the C++ client. 

Same for insert_ignore. delete_ignore and update_ignore are still in the works.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 21:08:53 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc@80
PS9, Line 80: the built-in client relies on the local machine's clock
> I think I'll do just that.
The alternative suggested by Greg need fixes.  I'll update the sentence.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 9
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:55:11 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 12:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@182
PS11, Line 182: 
              : * The `raft_term` and `time_since_last_leader_heartbeat` aggregated table
> Yes, I think that's a bug.  What's the semantics of sum of Raft terms?  It'
Done


http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@97
PS12, Line 97:   link:http://getkudu.io/docs/schema_design.html[schema design documentation]
> nit: they redirect to the same page, but maybe kudu.apache.org
Done


http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@114
PS12, Line 114: tablet replicas
> Raft leaders
Done


http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@123
PS12, Line 123: deletes
> delete
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 12
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 21:42:31 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#10) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................

[docs] add 1.12.0 release notes

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 214 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/10
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 10
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 13: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 13
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 22:09:11 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 9:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc@77
PS9, Line 77: is set
Style: 'is set' is for binary/boolean flags.  Please return back the original wording.

Also, this sentence is incorrect: it's not true that if --time_source=auto, then Kudu masters and tablet servers use the built-in NTP client.


http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc@78
PS9, Line 78: synchronizes
Synchronizes what?


http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc@80
PS9, Line 80: the built-in client relies on the local machine's clock
This is incorrect.  The built-in NTP client does not rely on the local machine clock.  In fact, that's the essence of the built-in NTP client to serve as the source of clock, not relying on the local clock.

Why not to use the alternative as suggested by Greg?  At least it's semantically correct.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 9
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:45:54 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 13: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 13
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 22:10:30 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 9:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15685/8/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/8/docs/release_notes.adoc@49
PS8, Line 49: Support for CentOS/RHEL 6, Debian 8, Ubuntu 14 has been deprecated and may
> Maybe "Support for CentOS/RHEL 6, Debian 8, Ubuntu 14 has been..."
Done


http://gerrit.cloudera.org:8080/#/c/15685/8/docs/release_notes.adoc@101
PS8, Line 101: 
             :   link:http://g
> link to that page.
Done


http://gerrit.cloudera.org:8080/#/c/15685/8/docs/release_notes.adoc@146
PS8, Line 146: 
> nit: extra space
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 9
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2020 23:55:26 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 8: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Apr 2020 05:59:22 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@49
PS5, Line 49: centos
nit: CentOS


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@85
PS5, Line 85: catalog manager
I think changing this to "masters" would make it easier to understand for users.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 14:36:15 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 5:

(8 comments)

Just noting some improvements/fixes that should be written. I'll take a swing at some of the ones I'm familiar with.

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@56
PS5, Line 56: == New features
Should add a note about columnar return type.
Should add a note about insert ignore et al.
Should add a note about the create table tool.


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@93
PS5, Line 93: [[rn_1.12.0_improvements]]
384a535a0 [cfile] KUDU-2852 Push predicate evaluation for int type RLE decoder
98f44f453 KUDU-2977 Sharding block map to speed up tserver startup
6b6910870 KUDU-3001 Multi-thread to load containers in a data directory
ac960b220 [metrics] Modify metrics 'raft_term' and 'time_since_last_leader_heartbeat' to MAX merge type
ca957fb86 [tablet] Add new metrics to indicate the last read/write time
59c5efbbd tserver: expose the number of round trips for a scanner [in the web UI]
e9656d0bc KUDU-3021 Add metric for tablet transaction memory.
9b7669f6a KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers
a20089faa rebalancer_tool: limit max_moves_per_server for PolicyFixer
0b99f37ea www: add tablet_count and on_disk_size on /tables, a5e58406a www: Add tablet On-Disk Size info to /table
c767bd114 KUDU-3032 Prevent selecting unnecessarily columns after scan optimization


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@147
PS5, Line 147: [[rn_1.12.0_fixed_issues]]
34efee128 [master] KUDU-2904 Crash master on disk error
23e07e3a9 KUDU-2992: Avoid sending duplicated requests in catalog_manager
8a30baea1 KUDU-3008 Spread replicas evenly with 2 locations and odd replica factors


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@217
PS5, Line 217: * Andy Singer
90c12dc27 [java] KUDU-3035: Pass last propagated timestamp in Batch


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@218
PS5, Line 218: * Michele Milesi
c8409bbda [Java] Fixed Type.getTypeForName method.


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@219
PS5, Line 219: * Ning Wang
1b3b26d95 KUDU-3070 skip open block manager


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@222
PS5, Line 222: * Thomas D'Silva
b58b37a1f KUDU-2162 Expose stats about scan filters


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@224
PS5, Line 224: * Waleed Fateem
5432d316a KUDU-3099: Remove System.exit() calls from KuduBackup/KuduRestore



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 19:16:59 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@49
PS5, Line 49: centos
> It looks like we have consensus around deprecating the following:
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 7
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Apr 2020 05:03:26 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 12: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@97
PS12, Line 97:   link:http://getkudu.io/docs/schema_design.html[schema design documentation]
nit: they redirect to the same page, but maybe kudu.apache.org


http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@114
PS12, Line 114: tablet replicas
Raft leaders


http://gerrit.cloudera.org:8080/#/c/15685/12/docs/release_notes.adoc@123
PS12, Line 123: deletes
delete



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 12
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 21:05:11 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Lieber-Dembo, Grant Henke, Hannah Nguyen, Greg Solovyev, Volodymyr Verovkin, Bankim Bhavsar, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15685

to look at the new patch set (#12).

Change subject: [docs] add 1.12.0 release notes
......................................................................

[docs] add 1.12.0 release notes

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 199 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/12
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 12
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has uploaded a new patch set (#6) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................

WIP [docs] Kudu 1.12 release notes draft

WIP:
  * this is published just as working draft to iterate upon

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 190 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has uploaded a new patch set (#7) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................

WIP [docs] Kudu 1.12 release notes draft

WIP:
  * this is published just as working draft to iterate upon

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 193 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/7
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 7
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................

WIP [docs] Kudu 1.12 release notes draft

WIP:
  * this is published just as working draft to iterate upon

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 77 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 5:

(11 comments)

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@56
PS5, Line 56: == New features
> I am not sure we want to add a note about columnar given it's experimental 
Do you think it's not worth documenting the auto rebalancer, given it's also marked experimental and defaulted to off?


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@75
PS5, Line 75: If setting
            :   `--time_source=auto`, Kudu masters and tablet servers use the built-in NTP
            :   client synchronized with dedicated NTP servers available via host-only
            :   network in AWS and GCE cloud environments, otherwise Kudu masters and tablet
            :   servers rely on local machine's clock synchronized by NTP
> I think this sentence needs to be broken up. E.g.:
Done


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@85
PS5, Line 85: catalog manager
> I think changing this to "masters" would make it easier to understand for u
Done


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@93
PS5, Line 93: [[rn_1.12.0_improvements]]
> 384a535a0 [cfile] KUDU-2852 Push predicate evaluation for int type RLE deco
Done


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@105
PS5, Line 105: * Kudu tablet servers and masters now expose a metric for the number of tablet
> should we mention the name of the metric here?
Done


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@118
PS5, Line 118: * The built-in NTP client is now fully supported as the time source for Kudu's
> I think this section and section about chronyd should be moved up right abo
I'm on the fence about this. I'll leave it as is -- others that may feel more strongly about this, feel free to update.


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@147
PS5, Line 147: [[rn_1.12.0_fixed_issues]]
> 34efee128 [master] KUDU-2904 Crash master on disk error
Done


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@217
PS5, Line 217: * Andy Singer
> 90c12dc27 [java] KUDU-3035: Pass last propagated timestamp in Batch
Done


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@219
PS5, Line 219: * Ning Wang
> 1b3b26d95 KUDU-3070 skip open block manager
Done


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@222
PS5, Line 222: * Thomas D'Silva
> b58b37a1f KUDU-2162 Expose stats about scan filters
Done


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@224
PS5, Line 224: * Waleed Fateem
> 5432d316a KUDU-3099: Remove System.exit() calls from KuduBackup/KuduRestore
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 23:29:00 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 11: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@133
PS11, Line 133: Web
nit: lower case, as it is in the rest of these notes.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 11
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 00:39:27 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Lieber-Dembo, Grant Henke, Hannah Nguyen, Greg Solovyev, Volodymyr Verovkin, Bankim Bhavsar, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15685

to look at the new patch set (#13).

Change subject: [docs] add 1.12.0 release notes
......................................................................

[docs] add 1.12.0 release notes

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 199 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/13
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 13
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@49
PS5, Line 49: centos
> nit: CentOS
It looks like we have consensus around deprecating the following:
- CentOS/RHEL 6
- Debian 8
- Ubuntu 14

I can get a docs patch up soon too.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 15:42:33 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 9: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 9
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 14:34:40 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 11:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@44
PS11, Line 44: authorization
nit: fine-grained authorization ?

Kudu has some level authz on itself using --user_acl and --superuser_acl


http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@105
PS11, Line 105: capacity planning file descriptor
              :   usage
file descriptor usage capacity planning

or

capacity planning of file descriptor usage


http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@182
PS11, Line 182: * The `raft_term` and `time_since_last_leader_heartbeat` aggregated table
              :   metrics will now return the maximum metric reported instead of the sum.
Should this be moved under the 'Fixed Issues' paragraph?


http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@239
PS11, Line 239: * Fixed an issue with Kudu Java client not being able to negotiate a secure
              :   connection with Kudu masters and tablet servers when using BouncyCastle
              :   JCE (see link:https://issues.apache.org/jira/browse/KUDU-3106[KUDU-3106]).
This seems to be a duplicate of the item at lines 212-214



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 11
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 04:53:33 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 9: Code-Review-1

Need to fix the time source section.


-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 9
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:46:57 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 12: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 12
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 12:46:57 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Lieber-Dembo, Grant Henke, Hannah Nguyen, Greg Solovyev, Volodymyr Verovkin, Bankim Bhavsar, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15685

to look at the new patch set (#11).

Change subject: [docs] add 1.12.0 release notes
......................................................................

[docs] add 1.12.0 release notes

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 202 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/11
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 11
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 12: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@182
PS11, Line 182: 
              : * The `raft_term` and `time_since_last_leader_heartbeat` aggregated table
> Do we consider this as a bug?  Otherwise I think it is an improvement.
Yes, I think that's a bug.  What's the semantics of sum of Raft terms?  It's a nonsense, I think

Feel free to leave it here, but I think that was a bug.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 12
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 03:05:47 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 11:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@44
PS11, Line 44: authorization
> nit: fine-grained authorization ?
Done


http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@105
PS11, Line 105: capacity planning file descriptor
              :   usage
> file descriptor usage capacity planning
Done


http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@133
PS11, Line 133: Web
> nit: lower case, as it is in the rest of these notes.
Done


http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@182
PS11, Line 182: * The `raft_term` and `time_since_last_leader_heartbeat` aggregated table
              :   metrics will now return the maximum metric reported instead of the sum.
> Should this be moved under the 'Fixed Issues' paragraph?
Do we consider this as a bug?  Otherwise I think it is an improvement.


http://gerrit.cloudera.org:8080/#/c/15685/11/docs/release_notes.adoc@239
PS11, Line 239: * Fixed an issue with Kudu Java client not being able to negotiate a secure
              :   connection with Kudu masters and tablet servers when using BouncyCastle
              :   JCE (see link:https://issues.apache.org/jira/browse/KUDU-3106[KUDU-3106]).
> This seems to be a duplicate of the item at lines 212-214
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 11
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 00:39:46 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#4) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................

WIP [docs] Kudu 1.12 release notes draft

WIP:
  * this is published just as working draft to iterate upon

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 104 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 10:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@40
PS10, Line 40: kudu-flume
> nit: wrap in ``s?
Done


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@60
PS10, Line 60:  (in addition to integration with Apache Sentry)
> nit: drop this? there is no additive authorization with both Sentry _and_ R
Done


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@79
PS10, Line 79:  other
             :   than AWS/GCE environments
> nit: "in environments other than AWS/GCE"
Done


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@80
PS10, Line 80: rely on local
             :   machine's clock
> nit: "rely on their local machine's clock"
Done


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@94
PS10, Line 94: * An experimental feature is added to Kudu that allows it to automatically
> Per KUDU-3113, I think we should drop this note for now.
Done


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@105
PS10, Line 105: * Bloom filter column predicate pushdown has been added as an experimental
> Sounds okay.
Done


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@145
PS10, Line 145: WebUI
> nit: web UI
Done


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@174
PS10, Line 174:  amount
> nit: the amount
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 10
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2020 23:37:21 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................

[docs] add 1.12.0 release notes

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Reviewed-on: http://gerrit.cloudera.org:8080/15685
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/release_notes.adoc
1 file changed, 199 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 14
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@56
PS5, Line 56: == New features
> Do you think it's not worth documenting the auto rebalancer, given it's als
Good question. I guess there is a difference between experimental because it needs to be tried more and users should try it and report back and experimental because it's still in progress or likely to change. I don't feel too strongly one way or another.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Apr 2020 01:05:38 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 8:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15685/8/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/8/docs/release_notes.adoc@49
PS8, Line 49: Support for older OS versions such as CentOS/RHEL 6, Debian 8, Ubuntu 14 have
Maybe "Support for CentOS/RHEL 6, Debian 8, Ubuntu 14 has been..."


http://gerrit.cloudera.org:8080/#/c/15685/8/docs/release_notes.adoc@62
PS8, Line 62: authorization documentation
link to the docs when available


http://gerrit.cloudera.org:8080/#/c/15685/8/docs/release_notes.adoc@101
PS8, Line 101: schema design
             :   documentation
link to that page.


http://gerrit.cloudera.org:8080/#/c/15685/8/docs/release_notes.adoc@146
PS8, Line 146:   
nit: extra space



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Apr 2020 18:50:43 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Lieber-Dembo, Grant Henke, Hannah Nguyen, Greg Solovyev, Volodymyr Verovkin, Bankim Bhavsar, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15685

to look at the new patch set (#9).

Change subject: [docs] add 1.12.0 release notes
......................................................................

[docs] add 1.12.0 release notes

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 202 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/9
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 9
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@118
PS5, Line 118:   usage.
> I'm on the fence about this. I'll leave it as is -- others that may feel mo
I think this item is not about a new feature, but rather about making already existing one kind of mainstream, removing the experimental tag.  IMHO, that makes this item to belong to this section, not 'New features'.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 10
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2020 03:37:08 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 4:

(4 comments)

I added a few comments here and added entries to the working google doc for them.

http://gerrit.cloudera.org:8080/#/c/15685/4/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/4/docs/release_notes.adoc@36
PS4, Line 36: == Obsoletions
We should note that the Flume sink has been removed from the kudu project and migrated to the Apache Flume project.

https://github.com/apache/kudu/commit/c8d36a9f9
https://github.com/apache/flume/commit/9dafe9897


http://gerrit.cloudera.org:8080/#/c/15685/4/docs/release_notes.adoc@40
PS4, Line 40: == Deprecations
I think we need to mark Sentry as deprecated so we can remove it in the next release.

We also want to deprecate Python 2 so we can officially drop support in the next release. 

We may also want to deprecate some older supported OSs (centOS6 6, Ubuntu 14, etc). However, we need community consensus on this. I will write up a proposal to the dev mailing list today.


http://gerrit.cloudera.org:8080/#/c/15685/4/docs/release_notes.adoc@44
PS4, Line 44: == New features
We should add DATE and VARCHAR support here.


http://gerrit.cloudera.org:8080/#/c/15685/4/docs/release_notes.adoc@82
PS4, Line 82: * Write Ahead Log file segments and index chunks are now managed by Kudu’s file
I will add a note for my metrics level filter improvement to the doc.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 15:57:54 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................

WIP [docs] Kudu 1.12 release notes draft

WIP:
  * this is published just as working draft to iterate upon

Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
---
M docs/release_notes.adoc
1 file changed, 72 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15685/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15685/4/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/4/docs/release_notes.adoc@36
PS4, Line 36: == Obsoletions
> We should note that the Flume sink has been removed from the kudu project a
Done


http://gerrit.cloudera.org:8080/#/c/15685/4/docs/release_notes.adoc@40
PS4, Line 40:   kudu-flume jars or migrate to the Flume jars containing the Kudu sink.
> I think we need to mark Sentry as deprecated so we can remove it in the nex
Ack


http://gerrit.cloudera.org:8080/#/c/15685/4/docs/release_notes.adoc@44
PS4, Line 44:   should migrate to the Apache Ranger integration for authorization.
> We should add DATE and VARCHAR support here.
Done


http://gerrit.cloudera.org:8080/#/c/15685/4/docs/release_notes.adoc@82
PS4, Line 82: 
> I will add a note for my metrics level filter improvement to the doc.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Sat, 11 Apr 2020 00:25:39 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc@80
PS9, Line 80: the built-in client relies on the local machine's clock
> This is incorrect.  The built-in NTP client does not rely on the local mach
I think I'll do just that.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 9
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:46:30 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 10:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@40
PS10, Line 40: kudu-flume
nit: wrap in ``s?


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@60
PS10, Line 60:  (in addition to integration with Apache Sentry)
nit: drop this? there is no additive authorization with both Sentry _and_ Ranger, so this might raise more questions than it answers.


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@79
PS10, Line 79:  other
             :   than AWS/GCE environments
nit: "in environments other than AWS/GCE"


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@80
PS10, Line 80: rely on local
             :   machine's clock
nit: "rely on their local machine's clock"


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@94
PS10, Line 94: * An experimental feature is added to Kudu that allows it to automatically
Per KUDU-3113, I think we should drop this note for now.


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@105
PS10, Line 105: * Bloom filter column predicate pushdown has been added as an experimental
Per https://gerrit.cloudera.org/c/15767/, I think we should drop this note for now.


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@145
PS10, Line 145: WebUI
nit: web UI


http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@174
PS10, Line 174:  amount
nit: the amount



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 10
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 May 2020 01:30:09 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@58
PS2, Line 58: Kudu now offers a tool to quiesce tablet servers
> "The `kudu tserver quiesce` tool is added to quiesce tablet servers."
Done


http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@63
PS2, Line 63: TODO: automatic tablet rebalancing
> Kudu can automatically rebalance tablet replicas among tablet servers. The 
Thank you!  I added this with minor modifications.


http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@74
PS2, Line 74: kudu fs update_dirs
> wrap in backticks
Done


http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@75
PS2, Line 75: recovery
> "recover"
Done


http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@81
PS2, Line 81: maintenance
> "maintenance operation"
Done


http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@84
PS2, Line 84: certain workloads
> "workloads that contained updates"
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 20:40:45 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: [docs] add 1.12.0 release notes
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/10/docs/release_notes.adoc@105
PS10, Line 105: * Bloom filter column predicate pushdown has been added as an experimental
> Per https://gerrit.cloudera.org/c/15767/, I think we should drop this note 
Sounds okay.



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 10
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 May 2020 15:34:38 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@75
PS5, Line 75: If setting
            :   `--time_source=auto`, Kudu masters and tablet servers use the built-in NTP
            :   client synchronized with dedicated NTP servers available via host-only
            :   network in AWS and GCE cloud environments, otherwise Kudu masters and tablet
            :   servers rely on local machine's clock synchronized by NTP
I think this sentence needs to be broken up. E.g.:

When the option is set to `--time_source=auto`, Kudu masters and tablet servers use the built-in NTP client. Built-in NTP client is synchronized with dedicated NTP servers available via host-only networks in AWS and GCE cloud environments. When dedicated NTP servers are not available, Kudu masters and tablet servers rely on local machine's clock synchronized by NTP.


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@105
PS5, Line 105: * Kudu tablet servers and masters now expose a metric for the number of tablet
should we mention the name of the metric here?
Also, I suggest moving this section to be right before or right after the section about metric severity levels.


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@118
PS5, Line 118: * The built-in NTP client is now fully supported as the time source for Kudu's
I think this section and section about chronyd should be moved up right above the section about --time_source



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 18:56:40 +0000
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

Posted by "Hannah Nguyen (Code Review)" <ge...@cloudera.org>.
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
......................................................................


Patch Set 2:

(1 comment)

Drafted a release note for auto-rebalancing!

http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/2/docs/release_notes.adoc@63
PS2, Line 63: TODO: automatic tablet rebalancing
Kudu can automatically rebalance tablet replicas among tablet servers. The background task can be enabled by setting the `auto_rebalancing_enabled` flag in the catalog manager. Before starting auto-rebalancing on an existing cluster, the CLI rebalancer tool should be run first (see link:https://issues.apache.org/jira/browse/KUDU-2780[KUDU-2780]).



-- 
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hannah Nguyen <ha...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 20:06:28 +0000
Gerrit-HasComments: Yes