You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jakarta.apache.org by Philippe Mouawad <pm...@apache.org> on 2011/10/13 19:28:56 UTC
Patch 52001
Hello Sebb,
Do you think we should implement issue
52001<https://issues.apache.org/bugzilla/show_bug.cgi?id=52001>
:
- Add scroll automatically to Summary Report
The only use case I see is when you label sampler with a variable name,
otherwise you may scroll but it won't last after some time number of lines
will stay the same.
If you give me the go, I will patch it.
Regards
Philippe
Re: Patch 52001
Posted by sebb <se...@gmail.com>.
On 13 October 2011 18:47, Philippe Mouawad <ph...@gmail.com> wrote:
> I agree with you.
By the way, please don't top-post; it's harder to follow the thread
when it appears in reverse order.
> Do we close the issue or we wait for other opinions ?
We can wait a while, and then close it.
> Thanks
> Regards
> Philippe
>
> On Thu, Oct 13, 2011 at 7:45 PM, sebb <se...@gmail.com> wrote:
>
>> On 13 October 2011 18:28, Philippe Mouawad <pm...@apache.org> wrote:
>> > Hello Sebb,
>> > Do you think we should implement issue
>> > 52001<https://issues.apache.org/bugzilla/show_bug.cgi?id=52001>
>> > :
>> >
>> > - Add scroll automatically to Summary Report
>> >
>> > The only use case I see is when you label sampler with a variable name,
>> > otherwise you may scroll but it won't last after some time number of
>> lines
>> > will stay the same.
>>
>> Yes, it's only needed in limited circumstances, which is why I don't
>> really see the need for it.
>>
>> > If you give me the go, I will patch it.
>>
>> It's not my personal decision; we make decisions by consensus.
>> Any committer can veto a change on a technical basis (e.g. it would
>> break something else) but that is probably not the case here.
>>
>> If it were me, I would not apply the patch as I cannot see the point;
>> more code to test and maintain with little benefit.
>>
>> So I don't support the patch, but if you feel it would be useful I
>> won't veto it.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: dev-help@jakarta.apache.org
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: dev-help@jakarta.apache.org
Re: Patch 52001
Posted by Philippe Mouawad <ph...@gmail.com>.
I agree with you.
Do we close the issue or we wait for other opinions ?
Thanks
Regards
Philippe
On Thu, Oct 13, 2011 at 7:45 PM, sebb <se...@gmail.com> wrote:
> On 13 October 2011 18:28, Philippe Mouawad <pm...@apache.org> wrote:
> > Hello Sebb,
> > Do you think we should implement issue
> > 52001<https://issues.apache.org/bugzilla/show_bug.cgi?id=52001>
> > :
> >
> > - Add scroll automatically to Summary Report
> >
> > The only use case I see is when you label sampler with a variable name,
> > otherwise you may scroll but it won't last after some time number of
> lines
> > will stay the same.
>
> Yes, it's only needed in limited circumstances, which is why I don't
> really see the need for it.
>
> > If you give me the go, I will patch it.
>
> It's not my personal decision; we make decisions by consensus.
> Any committer can veto a change on a technical basis (e.g. it would
> break something else) but that is probably not the case here.
>
> If it were me, I would not apply the patch as I cannot see the point;
> more code to test and maintain with little benefit.
>
> So I don't support the patch, but if you feel it would be useful I
> won't veto it.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: dev-help@jakarta.apache.org
>
>
--
Cordialement.
Philippe Mouawad.
Re: Patch 52001
Posted by sebb <se...@gmail.com>.
On 13 October 2011 18:28, Philippe Mouawad <pm...@apache.org> wrote:
> Hello Sebb,
> Do you think we should implement issue
> 52001<https://issues.apache.org/bugzilla/show_bug.cgi?id=52001>
> :
>
> - Add scroll automatically to Summary Report
>
> The only use case I see is when you label sampler with a variable name,
> otherwise you may scroll but it won't last after some time number of lines
> will stay the same.
Yes, it's only needed in limited circumstances, which is why I don't
really see the need for it.
> If you give me the go, I will patch it.
It's not my personal decision; we make decisions by consensus.
Any committer can veto a change on a technical basis (e.g. it would
break something else) but that is probably not the case here.
If it were me, I would not apply the patch as I cannot see the point;
more code to test and maintain with little benefit.
So I don't support the patch, but if you feel it would be useful I
won't veto it.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: dev-help@jakarta.apache.org