You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/05/04 00:12:01 UTC
Review Request 58980: Passed '--default_container_info' to the command
executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58980/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
Bugs: mesos-7007
https://issues.apache.org/jira/browse/mesos-7007
Repository: mesos
Description
-------
When there is no container info in the task info, copy that from the executor info so the command executor can set up the container correctly.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
Diff: https://reviews.apache.org/r/58980/diff/1/
Testing
-------
sudo make check
Manually tested on the scenario provided in mesos-7007.
Thanks,
Chun-Hung Hsiao
Re: Review Request 58980: Passed '--default_container_info' to the
command executor.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58980/#review173894
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58980]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 4, 2017, 12:12 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58980/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 12:12 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.
>
>
> Bugs: mesos-7007
> https://issues.apache.org/jira/browse/mesos-7007
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When there is no container info in the task info, copy that from the executor info so the command executor can set up the container correctly.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
>
>
> Diff: https://reviews.apache.org/r/58980/diff/1/
>
>
> Testing
> -------
>
> sudo make check
> Manually tested on the scenario provided in mesos-7007.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>