You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2019/05/29 07:28:00 UTC

[jira] [Resolved] (OAK-8365) UserManagerImpl: unreacheable code when retrieving user/group from ID and tree

     [ https://issues.apache.org/jira/browse/OAK-8365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved OAK-8365.
-------------------------
    Resolution: Fixed

Committed revision 1860319.


> UserManagerImpl: unreacheable code when retrieving user/group from ID and tree
> ------------------------------------------------------------------------------
>
>                 Key: OAK-8365
>                 URL: https://issues.apache.org/jira/browse/OAK-8365
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>             Fix For: 1.14.0
>
>
> when retrieving user/group by id or tree the user mgr implementation will verify that the id associated with a given tree actually is of type authorizable and return null if that's not the case. consequently, line 437 in {{UserManagerImpl}} will never be reached.
> [~stillalex], i will refactor the code such that the ID lookup is limited to one single place in {{getAuthorizable(Tree)}} and drop the extra if, which will not be reached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)