[jira] [Commented] (SOLR-11242) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

["Michael Braun (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-11242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127895#comment-16127895 ] 

Michael Braun commented on SOLR-11242:
--------------------------------------

I've attached a screenshot from JVisualVM showing what we're seeing. 

> QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance
> ---------------------------------------------------------------------------------------
>
>                 Key: SOLR-11242
>                 URL: https://issues.apache.org/jira/browse/SOLR-11242
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 7.0, 6.6.1, master (8.0)
>            Reporter: Michael Braun
>         Attachments: SOLR-11242.png
>
>
> Sampling of an application which includes a very heavy query load testing against an EmbeddedSolrServer reveals a huge amount of the time spent on initialization of the QueryParser itself, specifically an internal class called LookaheadSuccess which extends from Error. With every instance of QueryParser created, it spends time populating the stacktrace for this object, which is created as a final instance variable. 
> Ideally an exception shouldn't be used as a signaling mechanism, or at the very least, not an exception created on every single object instantiation. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org