You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2015/12/23 03:24:42 UTC
[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/397
TS-3235: fix crash problem caused by sync problem in PluginVC.
This is an updated version of PR 164 that has been tested in production. It attempts to fix the related issue in the C++ API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-3235
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/397.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #397
----
commit ffe0c19dbbcc3fe6b4bd41248c4d1515406398be
Author: zouyu <zo...@yahoo-inc.com>
Date: 2015-01-21T08:12:12Z
TS-3235: fix crash problem caused by sync problem in PluginVC.
This closes #164.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/397#issuecomment-166929171
Hmmm. I did use it at one point during development of this patch but it appears that code was removed. I'd prefer to leave it in for future use, although it's not actually needed for this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/397#issuecomment-166789440
What is ```ScopedContinuationLock``` for?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/397#issuecomment-166795111
I just meant that I didn't see it used in this patch. Did I look in the right place?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/397#issuecomment-166948715
Ah. Yep that seems fair enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/397#issuecomment-166794993
It lets the C++ API lock a mutex that is contained in a continuation in a scoped fashion. The already existing mutex locking mechanisms handle mutexes via the POSIX interface ({{pthread_mutex}} via {{pthread_mutex_lock}} and {{pthread_mutex_unlock}}). Those mutexes are completely independent of ATS provided mutexes. This makes mutual locking difficult. {{ScopedContinuationLock}} makes it possible for the C++ API to lock a continuation in a way that is detectable by core ATS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---