You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/23 16:36:53 UTC
[GitHub] [superset] kgabryje opened a new pull request, #22207: Fix/explore value undefined
kgabryje opened a new pull request, #22207:
URL: https://github.com/apache/superset/pull/22207
### SUMMARY
This PR fixes 2 issues:
1. Due to some faulty logic on the frontend, sometimes we converted `metric` control value from a string to an array. That resulted in `Unhashable type: 'list' error`.
2. When user opened a chart, changed dataset, then changed viz type, and then clicked "Update chart", Explore would crash with `undefined` error. That's because of the fact that we were expecting all the controls from the previous viz type to still be available and have values, which might not be the case after changing viz type.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
1.
https://user-images.githubusercontent.com/15073128/203598667-a73f8fd8-c648-423e-8914-e010144c35a5.mov
2.
https://user-images.githubusercontent.com/15073128/203598799-73d5e33f-b679-4cb5-8b5e-42e8315a26b0.mov
After:
1.
https://user-images.githubusercontent.com/15073128/203600227-494d33ec-07f4-4d1c-aac2-9bd122243bc3.mov
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #22207: fix(explore): Value undefined and Unhashable type errors
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #22207:
URL: https://github.com/apache/superset/pull/22207#issuecomment-1325429633
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #22207: fix(explore): Value undefined and Unhashable type errors
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #22207:
URL: https://github.com/apache/superset/pull/22207#discussion_r1030715466
##########
superset-frontend/src/explore/components/ControlPanelsContainer.tsx:
##########
@@ -276,21 +277,36 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
>(state => state.explore.controlsTransferred);
useEffect(() => {
+ const removeDatasourceWarningFromControl = (
Review Comment:
nit: Could we define this outside in a `useCallback`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22207: fix(explore): Value undefined and Unhashable type errors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22207:
URL: https://github.com/apache/superset/pull/22207#issuecomment-1325577097
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22207: fix(explore): Value undefined and Unhashable type errors
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22207:
URL: https://github.com/apache/superset/pull/22207#issuecomment-1325441989
# [Codecov](https://codecov.io/gh/apache/superset/pull/22207?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22207](https://codecov.io/gh/apache/superset/pull/22207?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (97a373f) into [master](https://codecov.io/gh/apache/superset/commit/d1567ba06d2907749aa4c0e8a1da91de5e497206?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1567ba) will **decrease** coverage by `0.00%`.
> The diff coverage is `9.09%`.
```diff
@@ Coverage Diff @@
## master #22207 +/- ##
==========================================
- Coverage 67.00% 66.99% -0.01%
==========================================
Files 1835 1835
Lines 69971 69976 +5
Branches 7590 7592 +2
==========================================
+ Hits 46881 46882 +1
- Misses 21124 21128 +4
Partials 1966 1966
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.80% <9.09%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/22207/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `75.35% <9.09%> (-2.03%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayersList.tsx](https://codecov.io/gh/apache/superset/pull/22207/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJzTGlzdC50c3g=) | `68.05% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22207: fix(explore): Value undefined and Unhashable type errors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22207:
URL: https://github.com/apache/superset/pull/22207#issuecomment-1325431617
@kgabryje Ephemeral environment spinning up at http://35.86.252.223:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #22207: fix(explore): Value undefined and Unhashable type errors
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #22207:
URL: https://github.com/apache/superset/pull/22207#discussion_r1030720240
##########
superset-frontend/src/explore/components/ControlPanelsContainer.tsx:
##########
@@ -276,21 +277,36 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
>(state => state.explore.controlsTransferred);
useEffect(() => {
+ const removeDatasourceWarningFromControl = (
Review Comment:
We could, but that wouldn't bring much value I think since we won't use it in any other place. I guess it's a style preference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #22207: fix(explore): Value undefined and Unhashable type errors
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #22207:
URL: https://github.com/apache/superset/pull/22207#discussion_r1030817308
##########
superset-frontend/src/explore/components/ControlPanelsContainer.tsx:
##########
@@ -276,21 +277,36 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
>(state => state.explore.controlsTransferred);
useEffect(() => {
+ const removeDatasourceWarningFromControl = (
Review Comment:
You're right, I've tended to err on the side of just spraying `useCallback` everywhere, but I agree it's not really needed in trivial cases like this where 1) creating it is dirt cheap 2) it's not being used in a prop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #22207: fix(explore): Value undefined and Unhashable type errors
Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on PR #22207:
URL: https://github.com/apache/superset/pull/22207#issuecomment-1329474365
🏷️ preset:2022.47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #22207: fix(explore): Value undefined and Unhashable type errors
Posted by GitBox <gi...@apache.org>.
kgabryje merged PR #22207:
URL: https://github.com/apache/superset/pull/22207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org