You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/12 05:00:08 UTC
[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request, #206: [FLINK-26639] Publish snapshot artifacts nightly
mbalassi opened a new pull request, #206:
URL: https://github.com/apache/flink-kubernetes-operator/pull/206
I was inspired by https://github.com/apache/spark/pull/30623, we have to merge it before I get to try it out since it needs to be on the apache account to work. I might still need to request the necessary secrets to be available (we already have some available for the docs upload).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #206: [FLINK-26639] Publish snapshot artifacts nightly
Posted by GitBox <gi...@apache.org>.
mbalassi commented on code in PR #206:
URL: https://github.com/apache/flink-kubernetes-operator/pull/206#discussion_r871050405
##########
.github/workflows/publish_snapshot.yml:
##########
@@ -0,0 +1,66 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+name: Publish Snapshot
+
+on:
+ schedule:
+ # At the end of every day
+ - cron: '0 0 * * *'
+ workflow_dispatch:
+jobs:
+ publish-snapshot:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ with:
+ ref: main
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'adopt'
+ - name: Cache local Maven repository
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: |
+ tmp_settings="tmp-settings.xml"
+ echo "<settings><servers><server>" > $tmp_settings
+ echo "<id>apache.snapshots.https</id><username>$ASF_USERNAME</username>" >> $tmp_settings
+ echo "<password>$ASF_PASSWORD</password>" >> $tmp_settings
+ echo "</server></servers></settings>" >> $tmp_settings
+
+ set -o pipefail; mvn clean deploy -Dgpg.skip -DskipTests -Papache-release | tee ./mvn.log; set +o pipefail
+ if [[ $(grep -c "overlapping classes" ./mvn.log) -gt 0 ]];then
+ echo "Found overlapping classes, please fix"
+ exit 1
+ fi
+ if [[ $(git diff HEAD | wc -l) -gt 0 ]];then
+ echo "Please generate the java doc via 'mvn clean install -DskipTests -Pgenerate-docs' again"
+ exit 1
+ fi
Review Comment:
Ok, going for the cheap option then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #206: [FLINK-26639] Publish snapshot artifacts nightly
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #206:
URL: https://github.com/apache/flink-kubernetes-operator/pull/206#discussion_r870957842
##########
.github/workflows/publish_snapshot.yml:
##########
@@ -0,0 +1,66 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+name: Publish Snapshot
+
+on:
+ schedule:
+ # At the end of every day
+ - cron: '0 0 * * *'
+ workflow_dispatch:
+jobs:
+ publish-snapshot:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ with:
+ ref: main
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'adopt'
+ - name: Cache local Maven repository
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: |
+ tmp_settings="tmp-settings.xml"
+ echo "<settings><servers><server>" > $tmp_settings
+ echo "<id>apache.snapshots.https</id><username>$ASF_USERNAME</username>" >> $tmp_settings
+ echo "<password>$ASF_PASSWORD</password>" >> $tmp_settings
+ echo "</server></servers></settings>" >> $tmp_settings
+
+ set -o pipefail; mvn clean deploy -Dgpg.skip -DskipTests -Papache-release | tee ./mvn.log; set +o pipefail
+ if [[ $(grep -c "overlapping classes" ./mvn.log) -gt 0 ]];then
+ echo "Found overlapping classes, please fix"
+ exit 1
+ fi
+ if [[ $(git diff HEAD | wc -l) -gt 0 ]];then
+ echo "Please generate the java doc via 'mvn clean install -DskipTests -Pgenerate-docs' again"
+ exit 1
+ fi
Review Comment:
That is also an option, I was suggesting to simply remove it. If it runs once somewhere else that is enough to generally fail the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #206: [FLINK-26639] Publish snapshot artifacts nightly
Posted by GitBox <gi...@apache.org>.
mbalassi commented on code in PR #206:
URL: https://github.com/apache/flink-kubernetes-operator/pull/206#discussion_r870957180
##########
.github/workflows/publish_snapshot.yml:
##########
@@ -0,0 +1,66 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+name: Publish Snapshot
+
+on:
+ schedule:
+ # At the end of every day
+ - cron: '0 0 * * *'
+ workflow_dispatch:
+jobs:
+ publish-snapshot:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ with:
+ ref: main
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'adopt'
+ - name: Cache local Maven repository
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: |
+ tmp_settings="tmp-settings.xml"
+ echo "<settings><servers><server>" > $tmp_settings
+ echo "<id>apache.snapshots.https</id><username>$ASF_USERNAME</username>" >> $tmp_settings
+ echo "<password>$ASF_PASSWORD</password>" >> $tmp_settings
+ echo "</server></servers></settings>" >> $tmp_settings
+
+ set -o pipefail; mvn clean deploy -Dgpg.skip -DskipTests -Papache-release | tee ./mvn.log; set +o pipefail
+ if [[ $(grep -c "overlapping classes" ./mvn.log) -gt 0 ]];then
+ echo "Found overlapping classes, please fix"
+ exit 1
+ fi
+ if [[ $(git diff HEAD | wc -l) -gt 0 ]];then
+ echo "Please generate the java doc via 'mvn clean install -DskipTests -Pgenerate-docs' again"
+ exit 1
+ fi
Review Comment:
Fair, I will refactor it to a common function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #206: [FLINK-26639] Publish snapshot artifacts nightly
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #206:
URL: https://github.com/apache/flink-kubernetes-operator/pull/206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #206: [FLINK-26639] Publish snapshot artifacts nightly
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #206:
URL: https://github.com/apache/flink-kubernetes-operator/pull/206#discussion_r870953886
##########
.github/workflows/publish_snapshot.yml:
##########
@@ -0,0 +1,66 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+name: Publish Snapshot
+
+on:
+ schedule:
+ # At the end of every day
+ - cron: '0 0 * * *'
+ workflow_dispatch:
+jobs:
+ publish-snapshot:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ with:
+ ref: main
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'adopt'
+ - name: Cache local Maven repository
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: |
+ tmp_settings="tmp-settings.xml"
+ echo "<settings><servers><server>" > $tmp_settings
+ echo "<id>apache.snapshots.https</id><username>$ASF_USERNAME</username>" >> $tmp_settings
+ echo "<password>$ASF_PASSWORD</password>" >> $tmp_settings
+ echo "</server></servers></settings>" >> $tmp_settings
+
+ set -o pipefail; mvn clean deploy -Dgpg.skip -DskipTests -Papache-release | tee ./mvn.log; set +o pipefail
+ if [[ $(grep -c "overlapping classes" ./mvn.log) -gt 0 ]];then
+ echo "Found overlapping classes, please fix"
+ exit 1
+ fi
+ if [[ $(git diff HEAD | wc -l) -gt 0 ]];then
+ echo "Please generate the java doc via 'mvn clean install -DskipTests -Pgenerate-docs' again"
+ exit 1
+ fi
Review Comment:
I think it would be better not to have these checks duplicated in all CI runs (we also might change some with the 1.15 bump)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org