[jira] Commented: (PIG-234) fix synchronization around staleCount in DataCollector

["Pi Song (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595119#action_12595119 ] 

Pi Song commented on PIG-234:
-----------------------------

Good eyes!!! Another bug from auto-boxing!!!

However:-
1. Currently we only run local execution engine in single-threaded mode so this buggy synchronization code doesn't cause any problem.
2. We are removing all of those spec classes as we are moving to the new pipeline design. Please have a look at PigType trunk. We need more people like you to help!!!

> fix synchronization around staleCount in DataCollector
> ------------------------------------------------------
>
>                 Key: PIG-234
>                 URL: https://issues.apache.org/jira/browse/PIG-234
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Chad Whipkey
>            Priority: Minor
>         Attachments: Change_synchronization_on_DataCollector.patch
>
>
> DataCollector uses synchronized statements on staleCount, but the staleCount reference changes!  I'm proposing it switch to use the concurrent package Lock and condition to manage staleness.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.