You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/05/23 14:58:00 UTC
[GitHub] [mynewt-mcumgr] mniestroj opened a new pull request #82: cmd/img_mgmt/port/zephyr: cast off_t to unsigned int before logging
mniestroj opened a new pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82
Following warning message appears when building Zephyr for qemu_x86 platform:
/zephyr/include/logging/log_core.h:238:10: warning: format '%x' \
expects argument of type 'unsigned int', but argument 3 has type \
'long unsigned int' [-Wformat=]
Suppress that by casting to unsigned int.
Signed-off-by: Marcin Niestroj <m....@grinn-global.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] mniestroj closed pull request #82: cmd/img_mgmt/port/zephyr: suppress warnings when building for qemu and native_posix
Posted by GitBox <gi...@apache.org>.
mniestroj closed pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] adityaxavier commented on pull request #82: cmd/img_mgmt/port/zephyr: suppress warnings when building for qemu and native_posix
Posted by GitBox <gi...@apache.org>.
adityaxavier commented on pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82#issuecomment-644074440
@mniestroj This patch is required if we use NEWLIB_LIBC. Maybe you should change the title accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] mniestroj commented on pull request #82: cmd/img_mgmt/port/zephyr: suppress warnings when building for qemu and native_posix
Posted by GitBox <gi...@apache.org>.
mniestroj commented on pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82#issuecomment-644083587
Here is Zephyr PR: https://github.com/zephyrproject-rtos/zephyr/pull/26184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] mniestroj commented on pull request #82: cmd/img_mgmt/port/zephyr: suppress warnings with logging enabled
Posted by GitBox <gi...@apache.org>.
mniestroj commented on pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82#issuecomment-644085413
> @mniestroj This patch is required if we use NEWLIB_LIBC. Maybe you should change the title accordingly.
I've changed the PR title to be more generic. It seems that there are lots of issues with the code, which I didn't notice in the beginning. Hopefully most of them are fixed with this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #82: cmd/img_mgmt/port/zephyr: suppress warnings when building for qemu and native_posix
Posted by GitBox <gi...@apache.org>.
de-nordic commented on pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82#issuecomment-644073963
>
>
> @de-nordic No, I don't. Should I create one for each Zephyr related changes (such as now)?
For each PR of module or dependent repo. This does two things: it makes it easier for reviewers to build the and test changes, because you give them the west that is supposed to reflect state of your repo; and it allows for Zephyr tests to run on your change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #82: cmd/img_mgmt/port/zephyr: suppress warnings with logging enabled
Posted by GitBox <gi...@apache.org>.
de-nordic commented on pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82#issuecomment-663134725
I have cherry picked the `cmd/img_mgmt/port/zephyr: suppress warnings with logging enabled` commit on to apache/mynewt-mcumgr master for test.
Compiled and loaded onto the nrf52840, everything seems ok. Needs rebasing and removal of `cmd/img_mgmt/port/zephyr: cast off_t to unsigned int before logging` which is no longer needed.
Otherwise it is fine, I will approve as soon as changes are applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] utzig merged pull request #82: cmd/img_mgmt/port/zephyr: suppress warnings with logging enabled
Posted by GitBox <gi...@apache.org>.
utzig merged pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] mniestroj commented on pull request #82: cmd/img_mgmt/port/zephyr: suppress warnings when building for qemu and native_posix
Posted by GitBox <gi...@apache.org>.
mniestroj commented on pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82#issuecomment-644062547
@de-nordic No, I don't. Should I create one for each Zephyr related changes (such as now)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #82: cmd/img_mgmt/port/zephyr: suppress warnings when building for qemu and native_posix
Posted by GitBox <gi...@apache.org>.
de-nordic commented on pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82#issuecomment-644059069
@mniestroj do you have Zephyr west.yaml update referencing this change?
(example here: https://github.com/zephyrproject-rtos/zephyr/pull/25711)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #82: cmd/img_mgmt/port/zephyr: suppress warnings with logging enabled
Posted by GitBox <gi...@apache.org>.
de-nordic commented on pull request #82:
URL: https://github.com/apache/mynewt-mcumgr/pull/82#issuecomment-663486051
@utzig Please merge. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org