[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #165: Fix `SETTINGS_HEADER_TABLE_SIZE` implementation

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #165: Fix `SETTINGS_HEADER_TABLE_SIZE` implementation
URL: https://github.com/apache/httpcomponents-core/pull/165#discussion_r357553203
 
 

 ##########
 File path: httpcore5-h2/src/main/java/org/apache/hc/core5/http2/config/H2Config.java
 ##########
 @@ -121,8 +121,7 @@ public String toString() {
                 .setPushEnabled(INIT_ENABLE_PUSH)
                 .setMaxConcurrentStreams(Integer.MAX_VALUE) // no limit
                 .setMaxFrameSize(INIT_MAX_FRAME_SIZE)
-                .setInitialWindowSize(INIT_WINDOW_SIZE)
-                .setHeaderTableSize(Integer.MAX_VALUE); // unlimited
+                .setInitialWindowSize(INIT_WINDOW_SIZE);
 
 Review comment:
   @rschmitt `.setHeaderTableSize(Integer.MAX_VALUE); // unlimited` should be `.setMaxHeaderListSize(Integer.MAX_VALUE); // unlimited`
   
   Mea culpa

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org