[GitHub] [commons-vfs] garydgregory commented on a change in pull request #92: [VFS-770] Gz createFileSystem fails

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #92:
URL: https://github.com/apache/commons-vfs/pull/92#discussion_r438026718



##########
File path: commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/test/DefaultFileSystemManagerTest.java
##########
@@ -63,4 +68,22 @@ public void testResolveFileObjectNullAbsolute() throws FileSystemException {
     public void testResolveFileNameNull() throws FileSystemException {
         VFS.getManager().resolveName((FileName) null, "../");
     }
+
+
+    @Test
+    public void testCreateGzipFileSystem() throws IOException {
+        // setup .gz file for test
+        final File gzFile = new File("src/test/resources/test-data/test.gz");
+        final File newGzFile = File.createTempFile(getClass().getSimpleName(), ".gz");
+        newGzFile.deleteOnExit();
+        FileUtils.copyFile(gzFile, newGzFile);
+        FileSystemManager manager = VFS.getManager();

Review comment:
       May you please either add a comment as to why this test needs its own copy of the file, or simplify the test. Can't the test use the file fixture as it stands? Assuming the test releasing resources works and there are no bugs at that level of course.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org