You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by dw...@apache.org on 2010/10/13 18:06:50 UTC

svn commit: r1022163 - /openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestGeneratedValues.java

Author: dwoods
Date: Wed Oct 13 16:06:49 2010
New Revision: 1022163

URL: http://svn.apache.org/viewvc?rev=1022163&view=rev
Log:
testcase wasn't committing/closing some EMs, so use new closeEM() helper

Modified:
    openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestGeneratedValues.java

Modified: openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestGeneratedValues.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestGeneratedValues.java?rev=1022163&r1=1022162&r2=1022163&view=diff
==============================================================================
--- openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestGeneratedValues.java (original)
+++ openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype/TestGeneratedValues.java Wed Oct 13 16:06:49 2010
@@ -66,6 +66,7 @@ public class TestGeneratedValues extends
         assertFalse(gv.getUuidhex().equals(gv2.getUuidhex()));
         assertFalse(gv.getUuidT4hex().equals(gv2.getUuidT4hex()));
         assertFalse(gv.getUuidT4string().equals(gv2.getUuidT4string()));
+        closeEM(em);
     }
     
     public void testInitialValues() { 
@@ -83,6 +84,8 @@ public class TestGeneratedValues extends
         }  catch (EntityExistsException eee) {
             // also ok
             return;
+        } finally {
+            closeEM(em);
         }
         
         // should not get here...
@@ -105,6 +108,8 @@ public class TestGeneratedValues extends
         }  catch (EntityExistsException eee) {
             // also ok
             return;
+        } finally {
+            closeEM(em);
         }
         
         // should not get here...
@@ -124,6 +129,8 @@ public class TestGeneratedValues extends
         } catch (InvalidStateException ise) {
             // expected result
             return;
+        } finally {
+            closeEM(em);
         }
         
         // should not get here...
@@ -154,6 +161,7 @@ public class TestGeneratedValues extends
         em.getTransaction().commit();
 
         assertNotEquals(0, gv.getCustomSeqWithIndirectionField());
+        closeEM(em);
     }
     
     public void testUUIDGenerators() {
@@ -199,6 +207,7 @@ public class TestGeneratedValues extends
         assertTrue(gv.getField() == gv2.getField());
         assertTrue(gv.getUuidhex().equals(gv2.getUuidhex()));
         assertTrue(gv.getUuidT4hex().equals(gv2.getUuidT4hex()));
+        closeEM(em);
     }
                 
     /*