You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Matteo Bertozzi (JIRA)" <ji...@apache.org> on 2014/09/19 20:23:33 UTC

[jira] [Created] (HBASE-12030) Wrong compaction report and assert when MOB compaction switches to minor

Matteo Bertozzi created HBASE-12030:
---------------------------------------

             Summary: Wrong compaction report and assert when MOB compaction switches to minor
                 Key: HBASE-12030
                 URL: https://issues.apache.org/jira/browse/HBASE-12030
             Project: HBase
          Issue Type: Bug
          Components: regionserver
    Affects Versions: hbase-11339
            Reporter: Matteo Bertozzi
            Priority: Critical
             Fix For: hbase-11339


when zookeeper is down during a major compaction, we switch to a minor.
{code}
try {
  zk = MobZookeeper.newInstance(this.conf, compactionName);
} catch (KeeperException e) {
  LOG.error("Cannot connect to the zookeeper, ready to perform the minor compaction instead", e);
  // change the major compaction into a minor one
  compaction.getRequest().setIsMajor(false);
  return super.compact(compaction);
}
{code}

but the "request start" (HRegion.reportCompactionRequestStart) is "major" and increments the major-compactions counter
while the "request end" (HRegion.reportCompactionRequestEnd) is "minor" and decrements the minor-compactions counter
triggering the assert newValue >= 0, since we are decrementing the wrong counter



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)