You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/09/26 12:59:28 UTC
[GitHub] [nifi] mcgilman commented on a diff in pull request #6437: NIFI-10538: UI updates for making RegistryClient an extension point
mcgilman commented on code in PR #6437:
URL: https://github.com/apache/nifi/pull/6437#discussion_r979979750
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-service.js:
##########
@@ -257,10 +257,12 @@
// reload
nfParameterProvider.reload(reference.id);
+ } else if (reference.referenceType === 'FlowRegistryClient') {
Review Comment:
I think something may have been mixed up during a rebase here.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-service.js:
##########
@@ -402,6 +404,36 @@
});
};
+ var updateValidationErrors = function (validationErrorIcon, referencingComponent) {
Review Comment:
This function appears to be a duplicate. Likely another mixed up with the rebase. Also, there's another condition that may have been missed. Search for 'ParameterProvider' to find other instances.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-flow-version.js:
##########
@@ -206,7 +206,8 @@
registries.push({
text: registry.name,
value: registry.id,
- description: nfCommon.escapeHtml(registry.description)
+ description: nfCommon.escapeHtml(registry.description),
+ disabled: registry.validationStatus !== 'VALID' // TODO: verify this logic is correct
Review Comment:
This looks correct but we should check with @simonbence or @markap14 who are a little more familiar with the backend effort [1].
[1] #6433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org