You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Jesus Camacho Rodriguez (JIRA)" <ji...@apache.org> on 2018/11/28 01:46:00 UTC
[jira] [Resolved] (CALCITE-2673) Default implementation of
SqlDialect should not support pushing all functions
[ https://issues.apache.org/jira/browse/CALCITE-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesus Camacho Rodriguez resolved CALCITE-2673.
----------------------------------------------
Resolution: Fixed
Thanks for the feedback [~julianhyde]. I have applied the changes based on the comments and merged in [249ec5975|http://git-wip-us.apache.org/repos/asf/calcite/commit/249ec5975].
> Default implementation of SqlDialect should not support pushing all functions
> -----------------------------------------------------------------------------
>
> Key: CALCITE-2673
> URL: https://issues.apache.org/jira/browse/CALCITE-2673
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Fix For: 1.18.0
>
>
> SqlDialect contains a 'supportsFunction' that can be used by rules to know whether a certain function is supported in the given dialect, e.g., to choose whether to push a Filter expression to JDBC, etc.
> The default implementation of 'supportsFunction' always returns true.
> I believe a better idea would be to support in the default implementation for the method the most common SQL functions. Then each dialect can override that behavior and expand/limit the supported functions, e.g., JethroDataDialect already does that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)