[jira] [Comment Edited] (PHOENIX-1678) Detect client server jar mismatch/incomatibility by looking at the jar version stored in the MANIFEST file

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490808#comment-14490808 ] 

James Taylor edited comment on PHOENIX-1678 at 4/11/15 5:49 AM:
----------------------------------------------------------------

[~ndimiduk] - seems like you may have done this in your QueryServer JIRA, no? Not the detecting part, but the part that gets the version from the MANIFEST based on built-time info?


was (Author: jamestaylor):
[~ndimiduk] - seems like you may have done this in your QueryServer JIRA, no?

> Detect client server jar mismatch/incomatibility by looking at the jar version stored in the MANIFEST file
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-1678
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1678
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>              Labels: Newbie
>
> Today, our way of detecting whether client and server jars are different is by comparing the static member variable values in MetadataProtocol.java. The check is hacky and could easily break once we start considering clusters upgraded to snapshot and "sunk" RC jars. The current mechanism is also prone to bugs when developers forget to change the member variable values even though they changed the underlying metadata. 
> If the jar names could be written to a MANIFEST file, then we can have a mechanism of detecting whether client and server jars belong to different versions or if they are incompatible. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)