You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/06/05 06:07:02 UTC
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 1): Fix the log directory for test redaction.py
Hello Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10604
to review the following change.
Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py
......................................................................
IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py
We don't get the Impalad logs when running the test_redaction.py custom
cluster test because the test sets the log directory to /tmp, and we do
not save the logs from there. In this patch we fix the problem by
correctly setting the logging directory in that test.
Change-Id: I82123ceea8633a5a0831019b810239fef3cd3212
Reviewed-on: http://gerrit.cloudera.org:8080/10599
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_redaction.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/10604/1
--
To view, visit http://gerrit.cloudera.org:8080/10604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82123ceea8633a5a0831019b810239fef3cd3212
Gerrit-Change-Number: 10604
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 1): Fix the log directory for test redaction.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10604 )
Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2593/
--
To view, visit http://gerrit.cloudera.org:8080/10604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I82123ceea8633a5a0831019b810239fef3cd3212
Gerrit-Change-Number: 10604
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 06:07:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 1): Fix the log directory for test redaction.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10604 )
Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I82123ceea8633a5a0831019b810239fef3cd3212
Gerrit-Change-Number: 10604
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 10:04:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 1): Fix the log directory for test redaction.py
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10604 )
Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py
......................................................................
IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py
We don't get the Impalad logs when running the test_redaction.py custom
cluster test because the test sets the log directory to /tmp, and we do
not save the logs from there. In this patch we fix the problem by
correctly setting the logging directory in that test.
Change-Id: I82123ceea8633a5a0831019b810239fef3cd3212
Reviewed-on: http://gerrit.cloudera.org:8080/10599
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/10604
---
M tests/custom_cluster/test_redaction.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I82123ceea8633a5a0831019b810239fef3cd3212
Gerrit-Change-Number: 10604
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 1): Fix the log directory for test redaction.py
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10604 )
Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I82123ceea8633a5a0831019b810239fef3cd3212
Gerrit-Change-Number: 10604
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 15:52:12 +0000
Gerrit-HasComments: No