[GitHub] [tvm] d-smirnov commented on a change in pull request #7817: RelayTextPrinter is now non-recursive. ExpandDataflow refactored

[GitBox <gi...@apache.org>]

d-smirnov commented on a change in pull request #7817:
URL: https://github.com/apache/tvm/pull/7817#discussion_r611881235



##########
File path: include/tvm/relay/expr_functor.h
##########
@@ -410,72 +414,82 @@ Expr PostOrderRewrite(const Expr& expr, ExprRewriter* rewriter);
  */
 void PostOrderVisit(const Expr& node, std::function<void(const Expr&)> fvisit);
 
+/*!
+ * \brief A struct to keep info of traversed expr in ExpandDataflow function
+ */
+struct v_info {
+  explicit v_info(Expr node_) : node{node_} {}
+  v_info(Expr node_, bool children_expanded_)
+      : node{node_}, children_expanded{children_expanded_} {};
+  Expr node{};
+  bool children_expanded{false};
+};

Review comment:
       Mainly for clarity reasons as the language allows us to have have a struct with proper filed names instead of meaningless key/value pair.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org