You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/27 06:06:22 UTC
[GitHub] [shardingsphere] captainbkarthick opened a new pull request, #21787: [ISSUE #21175] Add tests for PluginConfiguration class
captainbkarthick opened a new pull request, #21787:
URL: https://github.com/apache/shardingsphere/pull/21787
Fixes #21175 .
Changes proposed in this pull request:
- Add tests for PluginConfiguration class
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21787: [ISSUE #21175] Add tests for PluginConfiguration class
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21787:
URL: https://github.com/apache/shardingsphere/pull/21787#issuecomment-1293125258
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21787?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21787](https://codecov.io/gh/apache/shardingsphere/pull/21787?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (361ad0b) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ca3568a6babc80a28580b33a2dadd4a08f2090c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca3568a) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #21787 +/- ##
============================================
- Coverage 60.79% 60.78% -0.02%
Complexity 2446 2446
============================================
Files 4118 4121 +3
Lines 57478 57492 +14
Branches 9693 9693
============================================
+ Hits 34945 34946 +1
- Misses 19627 19639 +12
- Partials 2906 2907 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sphere/agent/api/point/PluginInterceptorPoint.java](https://codecov.io/gh/apache/shardingsphere/pull/21787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9hcGkvcG9pbnQvUGx1Z2luSW50ZXJjZXB0b3JQb2ludC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...phere/agent/api/result/MethodInvocationResult.java](https://codecov.io/gh/apache/shardingsphere/pull/21787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9hcGkvcmVzdWx0L01ldGhvZEludm9jYXRpb25SZXN1bHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...dingsphere/agent/api/advice/ConstructorAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/21787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9hcGkvYWR2aWNlL0NvbnN0cnVjdG9yQWR2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/agent/api/advice/InstanceMethodAroundAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/21787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9hcGkvYWR2aWNlL0luc3RhbmNlTWV0aG9kQXJvdW5kQWR2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gent/api/advice/ClassStaticMethodAroundAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/21787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9hcGkvYWR2aWNlL0NsYXNzU3RhdGljTWV0aG9kQXJvdW5kQWR2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ardingsphere/agent/config/PluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/21787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9jb25maWcvUGx1Z2luQ29uZmlndXJhdGlvbi5qYXZh) | `33.33% <0.00%> (+33.33%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #21787: [ISSUE #21175] Add tests for PluginConfiguration class
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21787:
URL: https://github.com/apache/shardingsphere/pull/21787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] captainbkarthick commented on pull request #21787: [ISSUE #21175] Add tests for PluginConfiguration class
Posted by GitBox <gi...@apache.org>.
captainbkarthick commented on PR #21787:
URL: https://github.com/apache/shardingsphere/pull/21787#issuecomment-1293042307
@terrymanu / @strongduanmu / @RaigorJiang
Requesting to check this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org