[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1712: SOLR-14702: Remove oppressive language (part1)

[GitBox <gi...@apache.org>]

tflobbe commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464603609



##########
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##########
@@ -1241,33 +1241,33 @@ public void inform(SolrCore core) {
       numberBackupsToKeep = 0;
     }
     @SuppressWarnings({"rawtypes"})
-    NamedList slave = (NamedList) initArgs.get("slave");
-    boolean enableSlave = isEnabled( slave );
-    if (enableSlave) {
-      currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(slave, this, core);
-      setupPolling((String) slave.get(POLL_INTERVAL));
-      isSlave = true;
+    NamedList secondary = (NamedList) initArgs.get("secondary");
+    boolean enableSecondary = isEnabled( secondary );
+    if (enableSecondary) {
+      currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(secondary, this, core);
+      setupPolling((String) secondary.get(POLL_INTERVAL));
+      isSecondary = true;
     }
     @SuppressWarnings({"rawtypes"})
-    NamedList master = (NamedList) initArgs.get("master");
-    boolean enableMaster = isEnabled( master );
+    NamedList primary = (NamedList) initArgs.get("primary");

Review comment:
       I don't think this discussion is resolved?
   > What's the real issue? Let's accept as input "master" or "primary" in one case and "slave" or "secondary" in the other, as well as send both values over the wire as output.
   This will make new code and old code compatible (old talking to new and new talking to old). Once only new code is running, we can safely remove sending or accepting the offending terms.
   
   +1, this should allow us to be backward compatible (and I'd even suggest we keep that for the life of 9 to make upgrades easy)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org