You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/27 16:54:53 UTC
[GitHub] [spark] huaxingao opened a new pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
huaxingao opened a new pull request #28657:
URL: https://github.com/apache/spark/pull/28657
### What changes were proposed in this pull request?
Add instance weight support in LogisticRegressionSummary
### Why are the changes needed?
LogisticRegression, MulticlassClassificationEvaluator and BinaryClassificationEvaluator support instance weight. We should support instance weight in LogisticRegressionSummary too.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Add new tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634808762
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634808717
**[Test build #123196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123196/testReport)** for PR 28657 at commit [`8ac2f3e`](https://github.com/apache/spark/commit/8ac2f3ea975d4c9cfc700a4a1fdc080fd5c8d579).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #28657:
URL: https://github.com/apache/spark/pull/28657#discussion_r432462642
##########
File path: project/MimaExcludes.scala
##########
@@ -45,7 +45,11 @@ object MimaExcludes {
// after: class ChiSqSelector extends PSelector
// false positive, no binary incompatibility
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.ChiSqSelectorModel"),
- ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.ChiSqSelector")
+ ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.ChiSqSelector"),
+
+ //[SPARK-31840] Add instance weight support in LogisticRegressionSummary
+ // weightCol in org.apache.spark.ml.classification.LogisticRegressionSummary is present only in current version
+ ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.ml.classification.LogisticRegressionSummary.weightCol")
Review comment:
Looks fine, that's a sealed trait anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #28657:
URL: https://github.com/apache/spark/pull/28657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-636528309
@srowen Thanks Sean!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634801505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634800418
**[Test build #123196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123196/testReport)** for PR 28657 at commit [`8ac2f3e`](https://github.com/apache/spark/commit/8ac2f3ea975d4c9cfc700a4a1fdc080fd5c8d579).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-636485839
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634958287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634805783
**[Test build #123197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123197/testReport)** for PR 28657 at commit [`b0f7bcc`](https://github.com/apache/spark/commit/b0f7bcc5d15be4e7e27aec8911775097a141f051).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634805783
**[Test build #123197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123197/testReport)** for PR 28657 at commit [`b0f7bcc`](https://github.com/apache/spark/commit/b0f7bcc5d15be4e7e27aec8911775097a141f051).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634836062
**[Test build #123198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123198/testReport)** for PR 28657 at commit [`df38f4e`](https://github.com/apache/spark/commit/df38f4e55693a08df4ff045e3579926b3d222266).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634957098
**[Test build #123198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123198/testReport)** for PR 28657 at commit [`df38f4e`](https://github.com/apache/spark/commit/df38f4e55693a08df4ff045e3579926b3d222266).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634958287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-635770681
cc @srowen @zhengruifeng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634818127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634836062
**[Test build #123198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123198/testReport)** for PR 28657 at commit [`df38f4e`](https://github.com/apache/spark/commit/df38f4e55693a08df4ff045e3579926b3d222266).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634808762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634832095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634800418
**[Test build #123196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123196/testReport)** for PR 28657 at commit [`8ac2f3e`](https://github.com/apache/spark/commit/8ac2f3ea975d4c9cfc700a4a1fdc080fd5c8d579).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634832095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634818071
**[Test build #123197 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123197/testReport)** for PR 28657 at commit [`b0f7bcc`](https://github.com/apache/spark/commit/b0f7bcc5d15be4e7e27aec8911775097a141f051).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634818127
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634808771
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123196/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634801505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28657:
URL: https://github.com/apache/spark/pull/28657#issuecomment-634818139
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123197/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org