You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/11 09:11:26 UTC

[GitHub] [apisix-dashboard] idbeta opened a new issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

idbeta opened a new issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786


   - Why do you submit this issue?
   - [ ] Question or discussion
   - [x] Bug
   - [ ] Requirements
   - [ ] Feature or performance improvement
   - [ ] Other
   __
   ### Bug
   - Which version of Apache APISIX Dashboard, OS, and Browser?
   APISIX master + dashabord 2.0 rc3
   
   1. create a route with adminAPI
   ```
   curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
    {
        "name":"test_route",
        "methods":["GET","POST"],
        "uri": "/name",
        "upstream": {
            "type": "roundrobin",
            "nodes": {
                "127.0.0.1:9797": 1
            }
        }
   }'
   ```
   2."upstream" cannot be displayed and modified by the dashboard
   ```
   ![image](https://user-images.githubusercontent.com/7396835/98792039-dbdaf980-2440-11eb-81f4-ab868164f5a8.png)
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729454603


   > I mean could @idbeta please check and paste the response from that page here?
   > 
   > [#786 (comment)](https://github.com/apache/apisix-dashboard/issues/786#issuecomment-725315724) this is valid for the frontend.
   
   sorry, I am late, I will check this today


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-727369777


   > May need API to check if the response data is valid.
   
   that is a valid format too. if we do not reformat the data in etcd, we need to compatible with this format.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399


   @juzhiyuan 
   ```
   Request URL: http://127.0.0.1:8080/apisix/admin/upstreams
   ```
   ```
   {"code":0,"message":"","data":{"rows":[],"total_size":0},"request_id":"e0f6114b-68a4-4019-968f-54dc30f5f678"}
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-725315724


   ![image](https://user-images.githubusercontent.com/2106987/98794814-72f58080-2444-11eb-83d3-fac145f0b542.png)
   
   May need API to check if the response data is valid.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399


   @juzhiyuan 
   there two api in this case
   click edit
   ```
   Request URL: http://127.0.0.1:8080/apisix/admin/routes/1
   {"code":0,"message":"","data":{"id":"1","create_time":0,"update_time":0,"uri":"/name","name":"test_route","methods":["GET","POST"],"upstream":{"nodes":{"127.0.0.1:9797":1},"type":"roundrobin","hash_on":"vars","pass_host":"pass"}},"request_id":"dd826fd2-5739-4f56-88a4-7659892a38c8"}
   ```
   click next to upstream
   ```
   Request URL: http://127.0.0.1:8080/apisix/admin/upstreams
   {"code":0,"message":"","data":{"rows":[],"total_size":0},"request_id":"e0f6114b-68a4-4019-968f-54dc30f5f678"}
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-727435472


   I mean could @idbeta please check and paste the response from that page here? 
   
   https://github.com/apache/apisix-dashboard/issues/786#issuecomment-725315724 this is valid for the frontend.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed issue #786: bug: when created route by adminAPI, "upstream" can not be modified by dashboard

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729542997


   > @juzhiyuan
   > there two apis in this case
   > click edit
   > 
   > ```
   > Request URL: http://127.0.0.1:8080/apisix/admin/routes/1
   > {"code":0,"message":"","data":{"id":"1","create_time":0,"update_time":0,"uri":"/name","name":"test_route","methods":["GET","POST"],"upstream":{"nodes":{"127.0.0.1:9797":1},"type":"roundrobin","hash_on":"vars","pass_host":"pass"}},"request_id":"dd826fd2-5739-4f56-88a4-7659892a38c8"}
   > ```
   > 
   > click next to upstream
   > 
   > ```
   > Request URL: http://127.0.0.1:8080/apisix/admin/upstreams
   > {"code":0,"message":"","data":{"rows":[],"total_size":0},"request_id":"e0f6114b-68a4-4019-968f-54dc30f5f678"}
   > ```
   
   Ya, from the first response, we can see `nodes`'s format is in the hash, and the frontend only supports Array.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729448689


   @nic-chen please confirm that is a bug of Manager-API. if yes, we need to update the label


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399


   @juzhiyuan 
   there two apis in this case
   click edit
   ```
   Request URL: http://127.0.0.1:8080/apisix/admin/routes/1
   {"code":0,"message":"","data":{"id":"1","create_time":0,"update_time":0,"uri":"/name","name":"test_route","methods":["GET","POST"],"upstream":{"nodes":{"127.0.0.1:9797":1},"type":"roundrobin","hash_on":"vars","pass_host":"pass"}},"request_id":"dd826fd2-5739-4f56-88a4-7659892a38c8"}
   ```
   click next to upstream
   ```
   Request URL: http://127.0.0.1:8080/apisix/admin/upstreams
   {"code":0,"message":"","data":{"rows":[],"total_size":0},"request_id":"e0f6114b-68a4-4019-968f-54dc30f5f678"}
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-725315877


   The snapshot above is taken from the manager-api


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399


   @juzhiyuan 
   ```
   Request URL: http://127.0.0.1:8080/apisix/admin/upstreams
   {"code":0,"message":"","data":{"rows":[],"total_size":0},"request_id":"e0f6114b-68a4-4019-968f-54dc30f5f678"}
   ```
   
   ```
   http://127.0.0.1:8080/apisix/admin/routes/1
   {"code":0,"message":"","data":{"id":"1","create_time":0,"update_time":0,"uri":"/name","name":"test_route","methods":["GET","POST"],"upstream":{"nodes":{"127.0.0.1:9797":1},"type":"roundrobin","hash_on":"vars","pass_host":"pass"}},"request_id":"dd826fd2-5739-4f56-88a4-7659892a38c8"}
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399


   @juzhiyuan 
   there two api in this case
   click edit
   ```
   http://127.0.0.1:8080/apisix/admin/routes/1
   {"code":0,"message":"","data":{"id":"1","create_time":0,"update_time":0,"uri":"/name","name":"test_route","methods":["GET","POST"],"upstream":{"nodes":{"127.0.0.1:9797":1},"type":"roundrobin","hash_on":"vars","pass_host":"pass"}},"request_id":"dd826fd2-5739-4f56-88a4-7659892a38c8"}
   ```
   click next to upstream
   ```
   Request URL: http://127.0.0.1:8080/apisix/admin/upstreams
   {"code":0,"message":"","data":{"rows":[],"total_size":0},"request_id":"e0f6114b-68a4-4019-968f-54dc30f5f678"}
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399


   @juzhiyuan 
   ```
   Request URL: http://127.0.0.1:8080/apisix/admin/upstreams
   ```
   ```
   {"code":0,"message":"","data":{"rows":[{"id":"foobar","create_time":0,"update_time":0,"nodes":{"127.0.0.1:9797":1},"type":"roundrobin","hash_on":"vars","pass_host":"pass"}],"total_size":1},"request_id":"da585937-4b75-4af0-b465-a95ac0e108df"}
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #786:
URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729464730


   > @nic-chen please confirm that is a bug of Manager-API. if yes, we need to update the label
   
   updated


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org