You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Branimir Lambov (JIRA)" <ji...@apache.org> on 2014/11/27 16:37:12 UTC

[jira] [Commented] (CASSANDRA-8385) Clean up generics in uses of AbstractType

    [ https://issues.apache.org/jira/browse/CASSANDRA-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227756#comment-14227756 ] 

Branimir Lambov commented on CASSANDRA-8385:
--------------------------------------------

Proposed patch is attached, comparison [here|https://github.com/blambov/cassandra/compare/generics-abstracttype].

Makes {{AbstractType}} and {{CollectionType}} interfaces without a generic parameter and moves the implementations to {{ConcreteType}} and {{ConcreteCollectionType}}. This helps clear up a couple of hundred raw types and unchecked cast warnings. Switches to Guava {{HashBasedTable}} as a replacement to {{HashMaps}} of pairs for looking up maps.

> Clean up generics in uses of AbstractType
> -----------------------------------------
>
>                 Key: CASSANDRA-8385
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8385
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Branimir Lambov
>            Assignee: Branimir Lambov
>         Attachments: 8385.patch
>
>
> Almost all uses of AbstractType are from code that doesn't know or care what the specific type is and would be better served by a non-generic version of the concept.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)