[jira] Commented: (THRIFT-414) Support non-UTF-8 in Java and C#

["Bryan Duxbury (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901046#action_12901046 ] 

Bryan Duxbury commented on THRIFT-414:
--------------------------------------

I would like to close this issue, as I think that Thrift shouldn't be in the business of allowing other string encodings. What do others think?

> Support non-UTF-8 in Java and C#
> --------------------------------
>
>                 Key: THRIFT-414
>                 URL: https://issues.apache.org/jira/browse/THRIFT-414
>             Project: Thrift
>          Issue Type: New Feature
>          Components: C# - Compiler, C# - Library, Cocoa - Compiler, Cocoa - Library, Java - Compiler, Java - Library
>            Reporter: David Reiss
>         Attachments: 0001-THRIFT-414.-Non-UTF-8-string-support-for-Java.patch, v2-0001-THRIFT-414.-Non-UTF-8-string-support-for-Java.patch
>
>
> Java and C# Thrift assume that all strings should be UTF-8.  A better approach would be:
>  - Give the readString and writeString protocol methods an encoding parameter, probably defaulting to UTF-8 for compatibility and convenience.
>  - Make generated struct readers and writers pass the argument to the protocol objects for each string.
>  - Allow a type annotation to override the default UTF-8 encoding.
>  - All other languages (except Python 3) should ignore the annotation, but it will serve as documentation for the application.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.